On 6/2/21 8:53 PM, Jason Thorpe wrote:
- if ((val & PCI_BASE_ADDRESS_MEM_TYPE_MASK)
+ if ((old & PCI_BASE_ADDRESS_SPACE_IO) == 0 &&
The correct test is
(old & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_MEMORY
Bitwise it's the same thing. I'll fix it up while applying.
> On Jun 3, 2021, at 2:24 AM, Philippe Mathieu-Daudé wrote:
>
> Hi Jason,
>
> On 6/3/21 5:53 AM, Jason Thorpe wrote:
>> Only program a BAR as a 64-bit MEM BAR if it really is a 64-bit MEM BAR.
>> Fixes an issue with the CMD646 IDE controller under NetBSD.
>
> OK for this fix,
>
>>
>> Improv
Hi Jason,
On 6/3/21 5:53 AM, Jason Thorpe wrote:
> Only program a BAR as a 64-bit MEM BAR if it really is a 64-bit MEM BAR.
> Fixes an issue with the CMD646 IDE controller under NetBSD.
OK for this fix,
>
> Improve some debug/info messages.
but I'm not sure why you changed the format.
Better s
Only program a BAR as a 64-bit MEM BAR if it really is a 64-bit MEM BAR.
Fixes an issue with the CMD646 IDE controller under NetBSD.
Improve some debug/info messages.
Signed-off-by: Jason Thorpe
---
pci.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/pci.c b/pci.c
i