Re: [PATCH 5/7] ui/vnc: clipboard support

2021-03-04 Thread Gerd Hoffmann
Hi, > > I don't see the > > agent doing the same (I might be missing something). > > Hmm, ok. Guess I should better be prepared to receive messages larger > than VD_AGENT_MAX_DATA_SIZE ... Confirmed. Cut+paste large text blocks in the guest -> hangs qemu vdagent implementation, because the m

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-03-04 Thread Gerd Hoffmann
On Wed, Mar 03, 2021 at 06:27:27PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Mar 3, 2021 at 4:13 PM Gerd Hoffmann wrote: > > > Hi, > > > > > > +case Z_BUF_ERROR: > > > > +out_len <<= 1; > > > > +if (out_len > (1 << 20)) { > > > > > > > > > > 1Mb isn't tha

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-03-03 Thread Marc-André Lureau
Hi On Wed, Mar 3, 2021 at 4:13 PM Gerd Hoffmann wrote: > Hi, > > > > +case Z_BUF_ERROR: > > > +out_len <<= 1; > > > +if (out_len > (1 << 20)) { > > > > > > > 1Mb isn't that much, is it? Well, since it handles only text for now it's > > probably enough. Would it

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-03-03 Thread Gerd Hoffmann
Hi, > > +case Z_BUF_ERROR: > > +out_len <<= 1; > > +if (out_len > (1 << 20)) { > > > > 1Mb isn't that much, is it? Well, since it handles only text for now it's > probably enough. Would it make sense to make this a #define for clarity ? Yep. While talking about

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-02-25 Thread Marc-André Lureau
On Fri, Feb 19, 2021 at 5:25 PM Gerd Hoffmann wrote: > This patch adds support for cut+paste to the qemu vnc server, which > allows the vnc client exchange clipbaord data with qemu and other peers > clipboard like the qemu vdagent implementation. > > Signed-off-by: Gerd Hoffmann > --- > ui/vn

[PATCH 5/7] ui/vnc: clipboard support

2021-02-19 Thread Gerd Hoffmann
This patch adds support for cut+paste to the qemu vnc server, which allows the vnc client exchange clipbaord data with qemu and other peers like the qemu vdagent implementation. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 24 ui/vnc-clipboard.c | 326 +