Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-11 Thread Jason Wang
On Fri, Apr 8, 2022 at 9:02 AM Si-Wei Liu wrote: > > > > On 4/7/2022 12:05 AM, Jason Wang wrote: > > > > 在 2022/4/6 上午3:18, Si-Wei Liu 写道: > >> > >> > >> On 4/1/2022 7:00 PM, Jason Wang wrote: > >>> On Sat, Apr 2, 2022 at 4:37 AM Si-Wei Liu > >>> wrote: > > > On 3/31/2022 1:36 AM,

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-07 Thread Si-Wei Liu
On 4/7/2022 12:05 AM, Jason Wang wrote: 在 2022/4/6 上午3:18, Si-Wei Liu 写道: On 4/1/2022 7:00 PM, Jason Wang wrote: On Sat, Apr 2, 2022 at 4:37 AM Si-Wei Liu wrote: On 3/31/2022 1:36 AM, Jason Wang wrote: On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: On 3/30/2022 2:14 AM, Jason

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-07 Thread Jason Wang
在 2022/4/6 上午3:18, Si-Wei Liu 写道: On 4/1/2022 7:00 PM, Jason Wang wrote: On Sat, Apr 2, 2022 at 4:37 AM Si-Wei Liu wrote: On 3/31/2022 1:36 AM, Jason Wang wrote: On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: On 3/30/2022 2:14 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 2:33 PM

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-05 Thread Si-Wei Liu
On 4/1/2022 7:00 PM, Jason Wang wrote: On Sat, Apr 2, 2022 at 4:37 AM Si-Wei Liu wrote: On 3/31/2022 1:36 AM, Jason Wang wrote: On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: On 3/30/2022 2:14 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: Previous commi

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-01 Thread Jason Wang
On Sat, Apr 2, 2022 at 4:37 AM Si-Wei Liu wrote: > > > > On 3/31/2022 1:36 AM, Jason Wang wrote: > > On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: > >> > >> > >> On 3/30/2022 2:14 AM, Jason Wang wrote: > >>> On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > Previous commit prevents v

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-01 Thread Si-Wei Liu
On 3/31/2022 1:36 AM, Jason Wang wrote: On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: On 3/30/2022 2:14 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: Previous commit prevents vhost-user and vhost-vdpa from using userland vq handler via disable_ioeventfd_ha

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-03-31 Thread Jason Wang
On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: > > > > On 3/30/2022 2:14 AM, Jason Wang wrote: > > On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > >> Previous commit prevents vhost-user and vhost-vdpa from using > >> userland vq handler via disable_ioeventfd_handler. The same > >> needs t

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-03-30 Thread Si-Wei Liu
On 3/30/2022 2:14 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: Previous commit prevents vhost-user and vhost-vdpa from using userland vq handler via disable_ioeventfd_handler. The same needs to be done for host notifier cleanup too, as the virtio_queue_host_notifie

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-03-30 Thread Jason Wang
On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > > Previous commit prevents vhost-user and vhost-vdpa from using > userland vq handler via disable_ioeventfd_handler. The same > needs to be done for host notifier cleanup too, as the > virtio_queue_host_notifier_read handler still tends to read >

[PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-03-29 Thread Si-Wei Liu
Previous commit prevents vhost-user and vhost-vdpa from using userland vq handler via disable_ioeventfd_handler. The same needs to be done for host notifier cleanup too, as the virtio_queue_host_notifier_read handler still tends to read pending event left behind on ioeventfd and attempts to handle