Re: [PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-31 Thread Cédric Le Goater
On 3/31/20 3:13 AM, David Gibson wrote: > On Mon, Mar 30, 2020 at 05:34:40PM +0200, Cédric Le Goater wrote: > +/* No valid pte or access denied due to protection */ > +if (cause_excp) { > +ppc_radix64_raise_si(cpu, rwx, eaddr, fault_cause); > +} >

Re: [PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread David Gibson
On Mon, Mar 30, 2020 at 05:34:40PM +0200, Cédric Le Goater wrote: > >>> +/* No valid pte or access denied due to protection */ > >>> +if (cause_excp) { > >>> +ppc_radix64_raise_si(cpu, rwx, eaddr, fault_cause); > >>> +} > >>> +return 1; > >>> +} > >>>

Re: [PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread Greg Kurz
On Mon, 30 Mar 2020 17:34:40 +0200 Cédric Le Goater wrote: > >>> +/* No valid pte or access denied due to protection */ > >>> +if (cause_excp) { > >>> +ppc_radix64_raise_si(cpu, rwx, eaddr, fault_cause); > >>> +} > >>> +return 1; > >>> +} > >>> + >

Re: [PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread Cédric Le Goater
>>> +/* No valid pte or access denied due to protection */ >>> +if (cause_excp) { >>> +ppc_radix64_raise_si(cpu, rwx, eaddr, fault_cause); >>> +} >>> +return 1; >>> +} >>> + >>> +ppc_radix64_set_rc(cpu, rwx, pte, pte_addr, g_prot); >>> + >>> +

Re: [PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread Cédric Le Goater
On 3/30/20 4:18 PM, Greg Kurz wrote: > On Mon, 30 Mar 2020 11:49:43 +0200 > Cédric Le Goater wrote: > >> This is moving code under a new ppc_radix64_xlate() routine shared by >> the MMU Radix page fault handler and the get_phys_page_debug PPC >> callback. The difference being that get_phys_page_d

Re: [PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread Greg Kurz
On Mon, 30 Mar 2020 11:49:43 +0200 Cédric Le Goater wrote: > This is moving code under a new ppc_radix64_xlate() routine shared by > the MMU Radix page fault handler and the get_phys_page_debug PPC > callback. The difference being that get_phys_page_debug does not > generate exceptions. > > The

[PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread Cédric Le Goater
This is moving code under a new ppc_radix64_xlate() routine shared by the MMU Radix page fault handler and the get_phys_page_debug PPC callback. The difference being that get_phys_page_debug does not generate exceptions. The specific part of process-scoped Radix translation is moved under ppc_radi