Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-09 Thread Nicholas Piggin
On Tue Aug 8, 2023 at 1:52 PM AEST, Pavel Dovgalyuk wrote: > On 08.08.2023 06:09, Nicholas Piggin wrote: > > On Sun Aug 6, 2023 at 9:46 PM AEST, Nicholas Piggin wrote: > >> On Fri Aug 4, 2023 at 6:50 PM AEST, Pavel Dovgalyuk wrote: > >>> BTW, there is a function qemu_register_reset_nosnapshotload t

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-07 Thread Pavel Dovgalyuk
On 08.08.2023 06:09, Nicholas Piggin wrote: On Sun Aug 6, 2023 at 9:46 PM AEST, Nicholas Piggin wrote: On Fri Aug 4, 2023 at 6:50 PM AEST, Pavel Dovgalyuk wrote: BTW, there is a function qemu_register_reset_nosnapshotload that can be used in similar cases. Can you just use it without changing t

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-07 Thread Nicholas Piggin
On Sun Aug 6, 2023 at 9:46 PM AEST, Nicholas Piggin wrote: > On Fri Aug 4, 2023 at 6:50 PM AEST, Pavel Dovgalyuk wrote: > > BTW, there is a function qemu_register_reset_nosnapshotload that can be > > used in similar cases. > > Can you just use it without changing the code of the reset handler? > >

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-06 Thread Nicholas Piggin
On Fri Aug 4, 2023 at 6:50 PM AEST, Pavel Dovgalyuk wrote: > BTW, there is a function qemu_register_reset_nosnapshotload that can be > used in similar cases. > Can you just use it without changing the code of the reset handler? I didn't know that, thanks for pointing it out. I'll take a closer lo

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-08-04 Thread Pavel Dovgalyuk
BTW, there is a function qemu_register_reset_nosnapshotload that can be used in similar cases. Can you just use it without changing the code of the reset handler? On 26.07.2023 21:35, Nicholas Piggin wrote: spapr_machine_reset gets a random number to populate the device-tree rng seed with. When

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-07-31 Thread Pavel Dovgalyuk
Acked-by: Pavel Dovgalyuk On 26.07.2023 21:35, Nicholas Piggin wrote: spapr_machine_reset gets a random number to populate the device-tree rng seed with. When loading a snapshot for record-replay, the machine is reset again, and that tries to consume the random event record again, crashing due

[PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-07-26 Thread Nicholas Piggin
spapr_machine_reset gets a random number to populate the device-tree rng seed with. When loading a snapshot for record-replay, the machine is reset again, and that tries to consume the random event record again, crashing due to inconsistent record Fix this by saving the seed to populate the device

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-06-26 Thread Nicholas Piggin
On Mon Jun 26, 2023 at 6:07 PM AEST, Pavel Dovgalyuk wrote: > e500 has the same problem, I think, according to this issue: > https://gitlab.com/qemu-project/qemu/-/issues/1634 Same symptoms. e500 looks like it does the dt build in machine_init_done notifier, though. Maybe I miss something. I'll t

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-06-26 Thread Pavel Dovgalyuk
e500 has the same problem, I think, according to this issue: https://gitlab.com/qemu-project/qemu/-/issues/1634 Btw, ARM virt platform rebuilds fdt only at initialization phase, not when reset. Isn't this behavior correct? Shouldn't PPC platforms do the similar thing? On 23.06.2023 15:57, Nic

[PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

2023-06-23 Thread Nicholas Piggin
spapr_machine_reset gets a random number to populate the device-tree rng seed with. When loading a snapshot for record-replay, the machine is reset again, and that tries to consume the random event record again, crashing due to inconsistent record Fix this by saving the seed to populate the device