Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread John Snow
On 10/28/20 4:13 AM, Thomas Huth wrote: On 27/10/2020 23.38, John Snow wrote: Ignore build and package output (build, dist, qemu.egg-info); effectively these are "in-tree" builds of a kind. Since we recently moved away from in-tree builds, could these also be made out-of-tree only? Thomas

Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread Daniel P . Berrangé
On Wed, Oct 28, 2020 at 09:39:07AM -0400, John Snow wrote: > On 10/28/20 5:16 AM, Markus Armbruster wrote: > > Thomas Huth writes: > > > > > On 27/10/2020 23.38, John Snow wrote: > > > > Ignore build and package output (build, dist, qemu.egg-info); > > > > effectively these are "in-tree" builds o

Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread John Snow
On 10/28/20 5:16 AM, Markus Armbruster wrote: Thomas Huth writes: On 27/10/2020 23.38, John Snow wrote: Ignore build and package output (build, dist, qemu.egg-info); effectively these are "in-tree" builds of a kind. Since we recently moved away from in-tree builds, could these also be made

Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread John Snow
On 10/28/20 4:13 AM, Thomas Huth wrote: On 27/10/2020 23.38, John Snow wrote: Ignore build and package output (build, dist, qemu.egg-info); effectively these are "in-tree" builds of a kind. Since we recently moved away from in-tree builds, could these also be made out-of-tree only? Thomas

Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread Daniel P . Berrangé
On Wed, Oct 28, 2020 at 10:16:33AM +0100, Markus Armbruster wrote: > Thomas Huth writes: > > > On 27/10/2020 23.38, John Snow wrote: > >> Ignore build and package output (build, dist, qemu.egg-info); > >> effectively these are "in-tree" builds of a kind. > > > > Since we recently moved away from

Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread Markus Armbruster
Thomas Huth writes: > On 27/10/2020 23.38, John Snow wrote: >> Ignore build and package output (build, dist, qemu.egg-info); >> effectively these are "in-tree" builds of a kind. > > Since we recently moved away from in-tree builds, could these also be made > out-of-tree only? The build should on

Re: [PATCH 4/5] python: add .gitignore

2020-10-28 Thread Thomas Huth
On 27/10/2020 23.38, John Snow wrote: > Ignore build and package output (build, dist, qemu.egg-info); > effectively these are "in-tree" builds of a kind. Since we recently moved away from in-tree builds, could these also be made out-of-tree only? Thomas

[PATCH 4/5] python: add .gitignore

2020-10-27 Thread John Snow
Ignore build and package output (build, dist, qemu.egg-info); effectively these are "in-tree" builds of a kind. Ignore miscellaneous cached python confetti (__pycache__, *.pyc, .mypy_cache). Ignore .idea (pycharm) and .venv (pipenv et al). Signed-off-by: John Snow --- python/.gitignore | 9 +++