Re: [PATCH 4/5] hw/nvme: basic directives support

2023-02-16 Thread Keith Busch
On Thu, Feb 16, 2023 at 06:35:27PM +0100, Klaus Jensen wrote: > On Thu, Feb 16, 2023, at 18:23, Keith Busch wrote: > > On Thu, Feb 16, 2023 at 05:48:05PM +0100, Jesper Devantier wrote: > >> +enum NvmeDirective { > >> +NVME_DIRECTIVE_SUPPORTED = 0x0, > >> +NVME_DIRECTIVE_ENABLED = 0x1, > >

Re: [PATCH 4/5] hw/nvme: basic directives support

2023-02-16 Thread Klaus Jensen
On Thu, Feb 16, 2023, at 18:23, Keith Busch wrote: > On Thu, Feb 16, 2023 at 05:48:05PM +0100, Jesper Devantier wrote: >> +enum NvmeDirective { >> +NVME_DIRECTIVE_SUPPORTED = 0x0, >> +NVME_DIRECTIVE_ENABLED = 0x1, >> +}; > > What's this? That’s a left-over from my rebase. I’ll fix tha

[PATCH 4/5] hw/nvme: basic directives support

2023-02-16 Thread Jesper Devantier
From: Gollu Appalanaidu Add support for the Directive Send and Recv commands and the Identify directive. Signed-off-by: Klaus Jensen Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 40 +++- hw/nvme/nvme.h | 2 ++ include/block/nvme.h | 35

Re: [PATCH 4/5] hw/nvme: basic directives support

2023-02-16 Thread Keith Busch
On Thu, Feb 16, 2023 at 05:48:05PM +0100, Jesper Devantier wrote: > +enum NvmeDirective { > +NVME_DIRECTIVE_SUPPORTED = 0x0, > +NVME_DIRECTIVE_ENABLED = 0x1, > +}; What's this?