Re: [PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it

2024-02-21 Thread Philippe Mathieu-Daudé
On 18/2/24 14:17, Bernhard Beschow wrote: This function is used once in the pc machines. Remove it since it contains one line only. Now reminds me of https://lore.kernel.org/qemu-devel/20211218130437.1516929-6-f4...@amsat.org/ Signed-off-by: Bernhard Beschow --- include/hw/input/i8042.h

Re: [PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it

2024-02-19 Thread Philippe Mathieu-Daudé
On 18/2/24 14:17, Bernhard Beschow wrote: This function is used once in the pc machines. Remove it since it contains one line only. Signed-off-by: Bernhard Beschow --- include/hw/input/i8042.h | 1 - hw/i386/pc.c | 2 +- hw/input/pckbd.c | 5 - 3 files changed, 1 in

[PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it

2024-02-18 Thread Bernhard Beschow
This function is used once in the pc machines. Remove it since it contains one line only. Signed-off-by: Bernhard Beschow --- include/hw/input/i8042.h | 1 - hw/i386/pc.c | 2 +- hw/input/pckbd.c | 5 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include