Fwd: [PATCH 4/4] vhost-user-blk: fix crash in realize process

2020-04-17 Thread Li Feng
Add mail group list. Thank you, Raphael . Raphael Norwitz 于2020年4月17日周五 下午12:10写道: > > Mostly looks good - just a few superficial notes. > > On Wed, Apr 15, 2020 at 11:28:26AM +0800, Li Feng wrote: > > 1. set s->connected to true after vhost_dev_init; > > 2. call vhost_dev_get_config when s->con

Re: [PATCH 4/4] vhost-user-blk: fix crash in realize process

2020-04-16 Thread Raphael Norwitz
Mostly looks good - just a few superficial notes. On Wed, Apr 15, 2020 at 11:28:26AM +0800, Li Feng wrote: > 1. set s->connected to true after vhost_dev_init; > 2. call vhost_dev_get_config when s->connected is true, otherwise the > hdev->host_ops will be nullptr. You mean hdev->vhost_ops, ri

[PATCH 4/4] vhost-user-blk: fix crash in realize process

2020-04-14 Thread Li Feng
The crash could be reproduced like this: 1. break vhost_user_write; 2. kill the vhost-user-blk target; 3. let qemu continue running; 4. start vhost-user-blk; 5. see crash! This fix makes changes: 1. set s->connected to true after vhost_dev_init; 2. call vhost_dev_get_config when s->connected is tr