Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Paolo Bonzini
On Mon, Jul 29, 2024 at 6:55 PM Kevin Wolf wrote: > Ok, so modifying the commit message and removing the 'error' > initialisation it is. Maybe mention the cluster validation case in the > comment here to explain why we do this even for non-pr-manager cases, > but not as a FIXME or TODO because it'

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Kevin Wolf
Am 29.07.2024 um 14:26 hat Paolo Bonzini geschrieben: > Il lun 29 lug 2024, 14:20 Kevin Wolf ha scritto: > > > Apparently both oVirt and Kubevirt unconditionally use the stop policy, > > so I'm afraid in this case we must acknowledge that our expectations > > don't match reality. > > > > Yeah, o

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Paolo Bonzini
On Mon, Jul 29, 2024 at 11:47 AM Kevin Wolf wrote: > RESERVATION_CONFLICT is not a backend error, but indicates that the > guest tried to make a request that it isn't allowed to execute. Pass the > error to the guest so that it can decide what to do with it. This is only true of scsi-block (thoug

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Paolo Bonzini
Il lun 29 lug 2024, 14:20 Kevin Wolf ha scritto: > Apparently both oVirt and Kubevirt unconditionally use the stop policy, > so I'm afraid in this case we must acknowledge that our expectations > don't match reality. > Yeah, of course. If I understand correctly, not having a pr-manager could me

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Kevin Wolf
Am 29.07.2024 um 13:55 hat Paolo Bonzini geschrieben: > On Mon, Jul 29, 2024 at 11:47 AM Kevin Wolf wrote: > > RESERVATION_CONFLICT is not a backend error, but indicates that the > > guest tried to make a request that it isn't allowed to execute. Pass the > > error to the guest so that it can deci

[PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Kevin Wolf
RESERVATION_CONFLICT is not a backend error, but indicates that the guest tried to make a request that it isn't allowed to execute. Pass the error to the guest so that it can decide what to do with it. Without this, if we stop the VM in response to a RESERVATION_CONFLICT, it can happen that the VM