Paolo Bonzini writes:
> On 12/15/22 07:49, Markus Armbruster wrote:
>>> linux-user/ does not use coroutines, so I'd like to avoid that it
>>> includes qemu/coroutine.h.
>> They include it even before the patch, via lockable.h.
>
> They do but there's a difference between "including lockable.h and
On 13/12/22 01:34, Paolo Bonzini wrote:
On 12/8/22 15:23, Markus Armbruster wrote:
> qemu/coroutine.h and qemu/lockable.h include each other. Neither
> header actually needs the other one.
qemu/lockable.h wants qemu/coroutine.h because of the reference to
qemu_co_mutex_loc
On 12/15/22 07:49, Markus Armbruster wrote:
linux-user/ does not use coroutines, so I'd like to avoid that it
includes qemu/coroutine.h.
They include it even before the patch, via lockable.h.
They do but there's a difference between "including lockable.h and
implictly getting coroutine.h due
Paolo Bonzini writes:
> dropped qemu-devel by mistake.
>
> Paolo
>
>
> Il lun 12 dic 2022, 23:16 Paolo Bonzini ha scritto:
>
>> On 12/8/22 15:23, Markus Armbruster wrote:
>> > qemu/coroutine.h and qemu/lockable.h include each other. Neither
>> > header actually needs the other one.
>>
>> qemu/l
dropped qemu-devel by mistake.
Paolo
Il lun 12 dic 2022, 23:16 Paolo Bonzini ha scritto:
> On 12/8/22 15:23, Markus Armbruster wrote:
> > qemu/coroutine.h and qemu/lockable.h include each other. Neither
> > header actually needs the other one.
>
> qemu/lockable.h wants qemu/coroutine.h becaus
Reviewed-by: Stefan Hajnoczi
qemu/coroutine.h and qemu/lockable.h include each other. Neither
header actually needs the other one.
Drop #include "qemu/coroutine.h" from qemu/lockable.h to break the
loop. All users of lockable.h actually need qemu/coroutine.h, so
adjust their #include directives.
I'm not dropping the #inclu
