Re: [PATCH 33/46] qom: Crash more nicely on object_property_get_link() failure

2020-07-02 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 6/24/20 11:43 AM, Markus Armbruster wrote: >>> Pass &error_abort instead of NULL where the returned value is >>> dereferenced or asserted to be non-null. >>> >>> Signed-off-by: Markus Armbruster >>> --- >> >>> @@ -63,8 +64,8 @@ hwaddr platf

Re: [PATCH 33/46] qom: Crash more nicely on object_property_get_link() failure

2020-06-25 Thread Markus Armbruster
Eric Blake writes: > On 6/24/20 11:43 AM, Markus Armbruster wrote: >> Pass &error_abort instead of NULL where the returned value is >> dereferenced or asserted to be non-null. >> >> Signed-off-by: Markus Armbruster >> --- > >> @@ -63,8 +64,8 @@ hwaddr platform_bus_get_mmio_addr(PlatformBusDevice

Re: [PATCH 33/46] qom: Crash more nicely on object_property_get_link() failure

2020-06-24 Thread Eric Blake
On 6/24/20 11:43 AM, Markus Armbruster wrote: Pass &error_abort instead of NULL where the returned value is dereferenced or asserted to be non-null. Signed-off-by: Markus Armbruster --- @@ -63,8 +64,8 @@ hwaddr platform_bus_get_mmio_addr(PlatformBusDevice *pbus, SysBusDevice *sbdev,

[PATCH 33/46] qom: Crash more nicely on object_property_get_link() failure

2020-06-24 Thread Markus Armbruster
Pass &error_abort instead of NULL where the returned value is dereferenced or asserted to be non-null. Signed-off-by: Markus Armbruster --- hw/core/platform-bus.c | 5 +++-- hw/ppc/spapr_drc.c | 3 ++- hw/ppc/spapr_hcall.c | 3 ++- hw/ppc/spapr_pci_nvlink2.c | 8 +--- ui/vn