Re: [PATCH 3/8] hw/pci: Document pci_dma_map()

2022-01-04 Thread Philippe Mathieu-Daudé
On Tue, Jan 4, 2022 at 8:27 AM Peter Xu wrote: > > On Fri, Dec 31, 2021 at 12:48:56PM +0100, Philippe Mathieu-Daudé wrote: > > +/** > > + * pci_dma_map: Map a physical memory region into a device PCI address > > space. > > Shouldn't this be: "Map device PCI address space range into host virtual >

Re: [PATCH 3/8] hw/pci: Document pci_dma_map()

2022-01-03 Thread Peter Xu
On Fri, Dec 31, 2021 at 12:48:56PM +0100, Philippe Mathieu-Daudé wrote: > +/** > + * pci_dma_map: Map a physical memory region into a device PCI address space. Shouldn't this be: "Map device PCI address space range into host virtual address"? -- Peter Xu

[PATCH 3/8] hw/pci: Document pci_dma_map()

2021-12-31 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 12 1 file changed, 12 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 5b36334a28a..f0d707efb8c 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -876,6 +876,18 @@ PCI_DMA_DEF