Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2024-01-09 Thread Richard Henderson
On 1/9/24 10:21, Philippe Mathieu-Daudé wrote: On 8/1/24 22:13, Richard Henderson wrote: On 1/9/24 04:15, Philippe Mathieu-Daudé wrote: +/* + * This can't go in hw/core/cpu.c because that file is compiled only + * once for both user-mode and system builds. + */   static Property cpu_common_prop

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2024-01-08 Thread Philippe Mathieu-Daudé
On 8/1/24 22:13, Richard Henderson wrote: On 1/9/24 04:15, Philippe Mathieu-Daudé wrote: +/* + * This can't go in hw/core/cpu.c because that file is compiled only + * once for both user-mode and system builds. + */   static Property cpu_common_props[] = { -#ifndef CONFIG_USER_ONLY +#ifdef CONFIG

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2024-01-08 Thread Richard Henderson
On 1/9/24 04:15, Philippe Mathieu-Daudé wrote: +/* + * This can't go in hw/core/cpu.c because that file is compiled only + * once for both user-mode and system builds. + */   static Property cpu_common_props[] = { -#ifndef CONFIG_USER_ONLY +#ifdef CONFIG_USER_ONLY   /* - * Create a memory

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2024-01-08 Thread Philippe Mathieu-Daudé
Hi Richard, (revisiting this old patch.) On 20/12/21 22:41, Richard Henderson wrote: This requires extra work for each target, but adds the common syscall code, and the necessary flag in CPUState. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- include/hw/core/cpu.h

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2021-12-24 Thread Richard Henderson
On 12/20/21 2:31 PM, Philippe Mathieu-Daudé wrote: +/* Used for user-only emulation of prctl(PR_SET_UNALIGN). */ +bool prctl_unalign_sigbus; Could we forward-declare a UserEmuCPUState structure in this file, use it here: struct UserEmuCPUState *user_cpu; and declare it in incl

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2021-12-22 Thread Laurent Vivier
Le 20/12/2021 à 22:41, Richard Henderson a écrit : This requires extra work for each target, but adds the common syscall code, and the necessary flag in CPUState. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 3 +++ linux-user/gen

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2021-12-20 Thread Philippe Mathieu-Daudé
On 12/20/21 22:41, Richard Henderson wrote: > This requires extra work for each target, but adds the > common syscall code, and the necessary flag in CPUState. > > Reviewed-by: Warner Losh > Signed-off-by: Richard Henderson > --- > include/hw/core/cpu.h | 3 +++ > linux-use

[PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2021-12-20 Thread Richard Henderson
This requires extra work for each target, but adds the common syscall code, and the necessary flag in CPUState. Reviewed-by: Warner Losh Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 3 +++ linux-user/generic/target_prctl_unalign.h | 27 ++