Re: [PATCH 3/6] iotests: move bitmap helpers into their own file

2020-03-03 Thread John Snow
On 2/27/20 5:54 AM, Vladimir Sementsov-Ogievskiy wrote: > > Clean code movement, no changes. If test passes, it should be correct :) > > The only thing: I'd prefer not exporting global variables and use > bitmaps.GROUPS instead (even then, it's not very good interface but..) > > with or witho

Re: [PATCH 3/6] iotests: move bitmap helpers into their own file

2020-02-27 Thread Vladimir Sementsov-Ogievskiy
25.02.2020 3:56, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/257| 110 +--- tests/qemu-iotests/bitmaps.py | 131 ++ 2 files changed, 132 insertions(+), 109 deletions(-) create mode 100644 tests/qemu-iotest

[PATCH 3/6] iotests: move bitmap helpers into their own file

2020-02-24 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/257| 110 +--- tests/qemu-iotests/bitmaps.py | 131 ++ 2 files changed, 132 insertions(+), 109 deletions(-) create mode 100644 tests/qemu-iotests/bitmaps.py diff --git a/tests/qemu-io