Re: [PATCH 3/5] migration: remove multifd check with postcopy

2024-11-05 Thread Prasad Pandit
On Mon, 4 Nov 2024 at 22:23, Peter Xu wrote: > We definitely need a helper like this to simply detect what the user chose > on the feature. > > You can still introduce a new helper, e.g. migrate_multifd_precopy(), if > that simplifies the code. Okay. Thank you. --- - Prasad

Re: [PATCH 3/5] migration: remove multifd check with postcopy

2024-11-04 Thread Peter Xu
On Mon, Nov 04, 2024 at 05:53:22PM +0530, Prasad Pandit wrote: > On Fri, 1 Nov 2024 at 20:06, Peter Xu wrote: > > > -return s->capabilities[MIGRATION_CAPABILITY_MULTIFD]; > > > +return s->capabilities[MIGRATION_CAPABILITY_MULTIFD] > > > +&& !migration_in_postcopy(); > > > } >

Re: [PATCH 3/5] migration: remove multifd check with postcopy

2024-11-04 Thread Prasad Pandit
On Fri, 1 Nov 2024 at 20:06, Peter Xu wrote: > > -return s->capabilities[MIGRATION_CAPABILITY_MULTIFD]; > > +return s->capabilities[MIGRATION_CAPABILITY_MULTIFD] > > +&& !migration_in_postcopy(); > > } > > We need to keep this as-is.. I'm afraid. > You can always do proper che

Re: [PATCH 3/5] migration: remove multifd check with postcopy

2024-11-01 Thread Peter Xu
On Tue, Oct 29, 2024 at 08:39:06PM +0530, Prasad Pandit wrote: > From: Prasad Pandit > > Remove multifd capability check with Postcopy mode. > This helps to enable both multifd and postcopy together. > > Update migrate_multifd() to return false when migration > reaches Postcopy phase. In Postcop

[PATCH 3/5] migration: remove multifd check with postcopy

2024-10-29 Thread Prasad Pandit
From: Prasad Pandit Remove multifd capability check with Postcopy mode. This helps to enable both multifd and postcopy together. Update migrate_multifd() to return false when migration reaches Postcopy phase. In Postcopy phase, source guest is paused, so the migration threads on the source stop