Re: [PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep

2021-11-11 Thread Paolo Bonzini
On 11/11/21 18:08, Alex Bennée wrote: + +/* + * In replay mode all events written into the log should be replayed. + * That is why NOIRQ flag is removed in this mode. I guess if we were being complete we could say something like: In replay mode all events will come from the log a

Re: [PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep

2021-11-11 Thread Paolo Bonzini
On 11/11/21 12:38, Philippe Mathieu-Daudé wrote: Simpler: gdbserver_state.supported_sstep_flags = SSTEP_ENABLE; +/* + * In replay mode all events written into the log should be replayed. + * That is why NOIRQ flag is removed in this mode. + */ if (replay_mode == REPLAY_MOD

Re: [PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep

2021-11-11 Thread Alex Bennée
Paolo Bonzini writes: > From: Maxim Levitsky > > handle_query_qemu_sstepbits is reporting NOIRQ and NOTIMER bits > even if they are not supported (as is the case with record/replay). > Instead, store the supported singlestep flags and reject > any unsupported bits in handle_set_qemu_sstep. Th

Re: [PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep

2021-11-11 Thread Philippe Mathieu-Daudé
On 11/11/21 12:06, Paolo Bonzini wrote: > From: Maxim Levitsky > > handle_query_qemu_sstepbits is reporting NOIRQ and NOTIMER bits > even if they are not supported (as is the case with record/replay). > Instead, store the supported singlestep flags and reject > any unsupported bits in handle_set_

[PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep

2021-11-11 Thread Paolo Bonzini
From: Maxim Levitsky handle_query_qemu_sstepbits is reporting NOIRQ and NOTIMER bits even if they are not supported (as is the case with record/replay). Instead, store the supported singlestep flags and reject any unsupported bits in handle_set_qemu_sstep. This removes the need for the get_sstep