Re: [PATCH 3/4] target/riscv: vector_helper: Fixup local variables shadowing

2023-09-25 Thread Daniel Henrique Barboza
On 9/25/23 01:30, Alistair Francis wrote: Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail on polling error". This patch removes th

[PATCH 3/4] target/riscv: vector_helper: Fixup local variables shadowing

2023-09-24 Thread Alistair Francis
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail on polling error". This patch removes the local variable shadowing. Tested by adding: