Re: [PATCH 3/4] qga-win: Fix guest-get-devices error API violations

2020-10-21 Thread Philippe Mathieu-Daudé
On 10/21/20 9:15 AM, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to

Re: [PATCH 3/4] qga-win: Fix guest-get-devices error API violations

2020-10-21 Thread Marc-André Lureau
On Wed, Oct 21, 2020 at 11:19 AM Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it

[PATCH 3/4] qga-win: Fix guest-get-devices error API violations

2020-10-21 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. qmp_guest_get_devices