Re: [PATCH 3/4] qga: Don't daemonize before channel is initialized

2024-12-05 Thread Michal Prívozník
On 12/4/24 10:44, Konstantin Kostiuk wrote: > > The old flow: > run_agent call run_agent_once in loop > run_agent_once initialize channel for every run > > after your changes > you expect to initialize the channel only once > this can cause issues on Windows during driver update > the default co

Re: [PATCH 3/4] qga: Don't daemonize before channel is initialized

2024-12-04 Thread Konstantin Kostiuk
On Mon, Nov 4, 2024 at 11:54 AM Michal Privoznik wrote: > If the agent is set to daemonize but for whatever reason fails to > init the channel, the error message is lost. Worse, the agent > daemonizes needlessly and returns success. For instance: > > # qemu-ga -m virtio-serial \ > -

[PATCH 3/4] qga: Don't daemonize before channel is initialized

2024-11-04 Thread Michal Privoznik
If the agent is set to daemonize but for whatever reason fails to init the channel, the error message is lost. Worse, the agent daemonizes needlessly and returns success. For instance: # qemu-ga -m virtio-serial \ -p /dev/nonexistent_device \ -f /run/qemu-ga.pid \