Re: [PATCH 3/4] hw/dma: xilinx_axidma: Reset qemu_irq when DMA/Stream is reset

2024-08-01 Thread Jim Shu
Hi Peter, Except DeviceState::reset(), stream_reset() is only used in axidma_write() and axidma_write() has qemu_set_irq() at the end of function. I think this commit could be dropped. I will remove it in the v2 patchset. Thanks, Jim Shu On Mon, Jul 29, 2024 at 11:23 PM Peter Maydell wrote:

Re: [PATCH 3/4] hw/dma: xilinx_axidma: Reset qemu_irq when DMA/Stream is reset

2024-07-29 Thread Peter Maydell
On Fri, 26 Jul 2024 at 06:59, Jim Shu wrote: > > Current DMA/Stream reset will clear interrupt pending bit of DMA device. > The qemu_irq of device should be updated at the same time. > > Signed-off-by: Jim Shu > --- > hw/dma/xilinx_axidma.c | 25 + > 1 file changed, 13 in

[PATCH 3/4] hw/dma: xilinx_axidma: Reset qemu_irq when DMA/Stream is reset

2024-07-25 Thread Jim Shu
Current DMA/Stream reset will clear interrupt pending bit of DMA device. The qemu_irq of device should be updated at the same time. Signed-off-by: Jim Shu --- hw/dma/xilinx_axidma.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/dma/xilinx_axid