Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-08-07 Thread Eduardo Habkost
On Fri, Aug 07, 2020 at 12:11:48PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 06, 2020 at 02:01:54PM -0400, Eduardo Habkost wrote: > > On Fri, Jul 24, 2020 at 10:12:45AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 23, 2020 at 02:50:06PM -0400, Eduardo Habkost wrote: > > > > On Th

Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-08-07 Thread Daniel P . Berrangé
On Thu, Aug 06, 2020 at 02:01:54PM -0400, Eduardo Habkost wrote: > On Fri, Jul 24, 2020 at 10:12:45AM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 23, 2020 at 02:50:06PM -0400, Eduardo Habkost wrote: > > > On Thu, Jul 23, 2020 at 07:14:09PM +0100, Daniel P. Berrangé wrote: > > > > This in

Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-08-06 Thread Eduardo Habkost
On Fri, Jul 24, 2020 at 10:12:45AM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 23, 2020 at 02:50:06PM -0400, Eduardo Habkost wrote: > > On Thu, Jul 23, 2020 at 07:14:09PM +0100, Daniel P. Berrangé wrote: > > > This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro > > > families

Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-07-24 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 02:50:06PM -0400, Eduardo Habkost wrote: > On Thu, Jul 23, 2020 at 07:14:09PM +0100, Daniel P. Berrangé wrote: > > This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro > > families in the secret types, in order to eliminate boilerplate code. > > > > Signed-

Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-07-23 Thread Eric Blake
On 7/23/20 1:14 PM, Daniel P. Berrangé wrote: This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro families in the secret types, in order to eliminate boilerplate code. Signed-off-by: Daniel P. Berrangé --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer R

Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-07-23 Thread Eduardo Habkost
On Thu, Jul 23, 2020 at 07:14:09PM +0100, Daniel P. Berrangé wrote: > This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro > families in the secret types, in order to eliminate boilerplate code. > > Signed-off-by: Daniel P. Berrangé > --- > crypto/secret.c | 24

[PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-07-23 Thread Daniel P . Berrangé
This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro families in the secret types, in order to eliminate boilerplate code. Signed-off-by: Daniel P. Berrangé --- crypto/secret.c | 24 crypto/secret_common.c | 32 +-