Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
11.10.2019 11:58, Max Reitz wrote: > On 11.10.19 10:33, Vladimir Sementsov-Ogievskiy wrote: >> 04.10.2019 19:31, Max Reitz wrote: >>> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up region in the dirty bitmap,

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
11.10.2019 11:58, Max Reitz wrote: > On 11.10.19 10:33, Vladimir Sementsov-Ogievskiy wrote: >> 04.10.2019 19:31, Max Reitz wrote: >>> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up region in the dirty bitmap,

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-11 Thread Max Reitz
On 11.10.19 10:33, Vladimir Sementsov-Ogievskiy wrote: > 04.10.2019 19:31, Max Reitz wrote: >> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: >>> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up >>> region in the dirty bitmap, which means that we may not copy some byt

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 19:31, Max Reitz wrote: > On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: >> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up >> region in the dirty bitmap, which means that we may not copy some bytes >> and assume them copied, which actually leads to produc

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up > region in the dirty bitmap, which means that we may not copy some bytes > and assume them copied, which actually leads to producing corrupted > target. > > So 9adc1cb4

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 18:27, Max Reitz wrote: > On 04.10.19 17:04, Vladimir Sementsov-Ogievskiy wrote: >> 04.10.2019 17:48, Max Reitz wrote: >>> On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: 04.10.2019 15:59, Max Reitz wrote: > On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: >> 02

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 04.10.19 17:04, Vladimir Sementsov-Ogievskiy wrote: > 04.10.2019 17:48, Max Reitz wrote: >> On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: >>> 04.10.2019 15:59, Max Reitz wrote: On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:52, Max Reitz wrote: >> On

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 17:48, Max Reitz wrote: > On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: >> 04.10.2019 15:59, Max Reitz wrote: >>> On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: 02.10.2019 18:52, Max Reitz wrote: > On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: >> 02

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: > 04.10.2019 15:59, Max Reitz wrote: >> On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: >>> 02.10.2019 18:52, Max Reitz wrote: On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:03, Vladimir Sementsov-Ogievsk

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 15:59, Max Reitz wrote: > On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: >> 02.10.2019 18:52, Max Reitz wrote: >>> On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: 02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 17:57, Max Reitz wrote: >> On

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:52, Max Reitz wrote: >> On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: >>> 02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: 02.10.2019 17:57, Max Reitz wrote: > On 12.09.19 17:13, Vladimir Sementsov-Ogievsk

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-03 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 18:52, Max Reitz wrote: > On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: >> 02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: >>> 02.10.2019 17:57, Max Reitz wrote: On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > Prior 9adc1cb49af8d do_sync_target_write had

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-02 Thread Max Reitz
On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: >> 02.10.2019 17:57, Max Reitz wrote: >>> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up region in

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 17:57, Max Reitz wrote: >> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: >>> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up >>> region in the dirty bitmap, which means that we may not copy some byte

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 17:57, Max Reitz wrote: > On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: >> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up >> region in the dirty bitmap, which means that we may not copy some bytes >> and assume them copied, which actually leads to produc

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-02 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up > region in the dirty bitmap, which means that we may not copy some bytes > and assume them copied, which actually leads to producing corrupted > target. > > So 9adc1cb4

[Qemu-devel] [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-09-12 Thread Vladimir Sementsov-Ogievskiy
Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up region in the dirty bitmap, which means that we may not copy some bytes and assume them copied, which actually leads to producing corrupted target. So 9adc1cb49af8d forced dirty bitmap granularity to be request_alignment for m