Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-28 Thread Philippe Mathieu-Daudé
On 28/12/22 19:30, Richard Henderson wrote: On 12/28/22 10:27, Philippe Mathieu-Daudé wrote: Oh, so you are using this variable as tri-state? Yes.  Perhaps a comment on the -1? Or name the variable tristate_lock? And a comment :) (No need to respin, you can keep my R-b).

Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-28 Thread Richard Henderson
On 12/28/22 10:27, Philippe Mathieu-Daudé wrote: Oh, so you are using this variable as tri-state? Yes. Perhaps a comment on the -1? r~

Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-28 Thread Philippe Mathieu-Daudé
On 28/12/22 18:36, Richard Henderson wrote: On 12/27/22 23:24, Philippe Mathieu-Daudé wrote: On 24/12/22 16:18, Richard Henderson wrote: As in page_get_flags, we need to try again with the mmap lock held if we fail a page lookup. Signed-off-by: Richard Henderson ---   accel/tcg/user-exec.c |

Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-28 Thread Richard Henderson
On 12/27/22 23:24, Philippe Mathieu-Daudé wrote: On 24/12/22 16:18, Richard Henderson wrote: As in page_get_flags, we need to try again with the mmap lock held if we fail a page lookup. Signed-off-by: Richard Henderson ---   accel/tcg/user-exec.c | 39 ---  

Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-28 Thread Philippe Mathieu-Daudé
On 28/12/22 08:24, Philippe Mathieu-Daudé wrote: On 24/12/22 16:18, Richard Henderson wrote: As in page_get_flags, we need to try again with the mmap lock held if we fail a page lookup. Signed-off-by: Richard Henderson ---   accel/tcg/user-exec.c | 39 ---  

Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-27 Thread Philippe Mathieu-Daudé
On 24/12/22 16:18, Richard Henderson wrote: As in page_get_flags, we need to try again with the mmap lock held if we fail a page lookup. Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-)

[PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range

2022-12-24 Thread Richard Henderson
As in page_get_flags, we need to try again with the mmap lock held if we fail a page lookup. Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/u