Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-08 Thread Richard Henderson
On 9/6/22 15:22, Víctor Colombo wrote: On 05/09/2022 14:20, Richard Henderson wrote: Well, there would of course be no separate call, but I didn't understand what you meant here with 'no separate call'... We generate a separate call from tcg to helper_reset_fpstatus sometimes. Right, makes

Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-06 Thread Víctor Colombo
On 05/09/2022 14:20, Richard Henderson wrote: Well, there would of course be no separate call, but I didn't understand what you meant here with 'no separate call'... do_float_check_status would:     int status = get_float_exception_flags(&env->fp_status);     set_float_exception_flags(0,

Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-05 Thread Richard Henderson
On 9/5/22 17:31, Víctor Colombo wrote: I have a message bookmarked here ([1]), but I don't know if there is a previous one with a more in depth scheme. There may have been a previous, but that's the one I was thinking of. Anyway, I was also analyzing recently the idea of removing all these re

Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-05 Thread Víctor Colombo
On 05/09/2022 13:21, Richard Henderson wrote: On 9/5/22 17:19, Víctor Colombo wrote: Existing bug, but this is missing to clear fp status to start. Reviewed-by: Richard Henderson r~ Hello Richard, thanks for your review! gen_reset_fpstatus() is called by the inline implementation in do_hel

Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-05 Thread Richard Henderson
On 9/5/22 17:19, Víctor Colombo wrote: Existing bug, but this is missing to clear fp status to start. Reviewed-by: Richard Henderson r~ Hello Richard, thanks for your review! gen_reset_fpstatus() is called by the inline implementation in do_helper_fsqrt() before calling the helper (patch 1)

Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-05 Thread Víctor Colombo
On 05/09/2022 12:56, Richard Henderson wrote: On 9/5/22 13:37, Víctor Colombo wrote: These two helpers are almost identical, differing only by the softfloat operation it calls. Merge them into one using a macro. Also, take this opportunity to capitalize the helper name as we moved the instructio

Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-05 Thread Richard Henderson
On 9/5/22 13:37, Víctor Colombo wrote: These two helpers are almost identical, differing only by the softfloat operation it calls. Merge them into one using a macro. Also, take this opportunity to capitalize the helper name as we moved the instruction to decodetree in a previous patch. Signed-of

[PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

2022-09-05 Thread Víctor Colombo
These two helpers are almost identical, differing only by the softfloat operation it calls. Merge them into one using a macro. Also, take this opportunity to capitalize the helper name as we moved the instruction to decodetree in a previous patch. Signed-off-by: Víctor Colombo --- target/ppc/fpu