Re: [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning

2022-12-21 Thread Richard Henderson
On 12/20/22 23:16, Philippe Mathieu-Daudé wrote: However I find '{ /* end of list */ }' cleaner/clearer than assigning the first field. I agree with that, for those cases we don't already have a separate sentinal define. r~

Re: [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning

2022-12-20 Thread Philippe Mathieu-Daudé
On 21/12/22 02:01, Richard Henderson wrote: On 12/20/22 06:25, Philippe Mathieu-Daudé wrote: Silent when compiling with -Wextra:    ../hw/arm/nseries.c:1081:12: warning: missing field 'line' initializer [-Wmissing-field-initializers]    { NULL }   ^ Signed-off-by: Philippe Ma

Re: [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning

2022-12-20 Thread Richard Henderson
On 12/20/22 06:25, Philippe Mathieu-Daudé wrote: Silent when compiling with -Wextra: ../hw/arm/nseries.c:1081:12: warning: missing field 'line' initializer [-Wmissing-field-initializers] { NULL } ^ Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/nseries.c | 10 --

[PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning

2022-12-20 Thread Philippe Mathieu-Daudé
Silent when compiling with -Wextra: ../hw/arm/nseries.c:1081:12: warning: missing field 'line' initializer [-Wmissing-field-initializers] { NULL } ^ Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/nseries.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)