Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote: > Corey Minyard writes: > > > Is this official coding style? I'm not a big fan of having return > > statements in the middle of functions, I generally only put them at > > the beginning or the end. > > There's nothing in docs/de

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

Is this official coding style? I'm not a big fan of having return statements in the middle of functions, I generally only put them at the beginning or the end. -corey On Wed, Mar 19, 2025 at 10:26 AM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > hw/ipmi/ipmi_bmc_extern

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

On Wed, Mar 19, 2025 at 02:42:21PM -0500, Corey Minyard wrote: > On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote: > > Corey Minyard writes: > > > > > Is this official coding style? I'm not a big fan of having return > > > statements in the middle of functions, I generally only

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

On Wed, Mar 19, 2025 at 03:51:45PM -0500, Corey Minyard wrote: > On Wed, Mar 19, 2025 at 08:49:01PM +0100, Markus Armbruster wrote: > > Corey Minyard writes: > > > > > On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote: > > >> Corey Minyard writes: > > >> > > >> > Is this officia

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

Markus Armbruster writes: > Corey Minyard writes: > >> Is this official coding style? I'm not a big fan of having return >> statements in the middle of functions, I generally only put them at >> the beginning or the end. > > There's nothing in docs/devel/style.rst. > > I count more than 42,000

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

On Wed, Mar 19, 2025 at 08:49:01PM +0100, Markus Armbruster wrote: > Corey Minyard writes: > > > On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote: > >> Corey Minyard writes: > >> > >> > Is this official coding style? I'm not a big fan of having return > >> > statements in the

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

Corey Minyard writes: > On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote: >> Corey Minyard writes: >> >> > Is this official coding style? I'm not a big fan of having return >> > statements in the middle of functions, I generally only put them at >> > the beginning or the end.

Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

Corey Minyard writes: > Is this official coding style? I'm not a big fan of having return > statements in the middle of functions, I generally only put them at > the beginning or the end. There's nothing in docs/devel/style.rst. I count more than 42,000 return statements with indentation > 4.

[PATCH 3/3] cleanup: Drop pointless label at end of function

Signed-off-by: Markus Armbruster --- hw/ipmi/ipmi_bmc_extern.c | 4 +--- hw/ipmi/ipmi_bmc_sim.c| 7 ++- hw/ipmi/ipmi_bt.c | 7 +++ hw/ipmi/ipmi_kcs.c| 3 +-- 4 files changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_ex