Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/22/23 8:04 AM, Stefan Berger wrote: On 3/22/23 07:50, Stefan Berger wrote: On 3/22/23 07:28, Ninad Palsule wrote: On 3/21/23 8:30 PM, Stefan Berger wrote: I think there should be tpm_tis_set_data_buffer function that you can call rather than transferring the data byte-by-byte

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/22/23 6:50 AM, Stefan Berger wrote: On 3/22/23 07:28, Ninad Palsule wrote: On 3/21/23 8:30 PM, Stefan Berger wrote: On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C mod

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Stefan Berger
On 3/22/23 07:50, Stefan Berger wrote: On 3/22/23 07:28, Ninad Palsule wrote: On 3/21/23 8:30 PM, Stefan Berger wrote: I think there should be tpm_tis_set_data_buffer function that you can call rather than transferring the data byte-by-byte. Thanks for the series!   Stefan I tho

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Stefan Berger
On 3/22/23 07:28, Ninad Palsule wrote: On 3/21/23 8:30 PM, Stefan Berger wrote: On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. + +/* Se

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/21/23 8:30 PM, Stefan Berger wrote: On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. + +/* Send data to TPM */ +static inline void tpm_

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/21/23 8:10 PM, Stefan Berger wrote: On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - A

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-21 Thread Stefan Berger
On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. + +/* Send data to TPM */ +static inline void tpm_tis_i2c_tpm_send(TPMStateI2C *i2cst) +{ +

Re: [PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-21 Thread Stefan Berger
On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - Added I2C emulation model. Logic was added i

[PATCH 3/3] Add support for TPM devices over I2C bus

2023-03-21 Thread Ninad Palsule
Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - Added I2C emulation model. Logic was added in the model to temporarily cache the data