Re: [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags

2022-06-06 Thread Richard Henderson
On 6/6/22 08:58, Peter Maydell wrote: +if (FIELD_EX64(env->svcr, SVCR, SM)) { +DP_TBFLAG_A64(flags, PSTATE_SM, 1); +} +DP_TBFLAG_A64(flags, PSTATE_ZA, FIELD_EX64(env->svcr, SVCR, ZA)); Why did you write these two differently? Don't they do the same thing (set

Re: [PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags

2022-06-06 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:22, Richard Henderson wrote: > > These are required to determine if various insns > are allowed to issue. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 2 ++ > target/arm/translate.h | 4 > target/arm/helper.c| 4 > targe

[PATCH 28/71] target/arm: Add PSTATE.{SM,ZA} to TB flags

2022-06-02 Thread Richard Henderson
These are required to determine if various insns are allowed to issue. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 ++ target/arm/translate.h | 4 target/arm/helper.c| 4 target/arm/translate-a64.c | 2 ++ 4 files changed, 12 insertions(+) diff --gi