Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread Richard Henderson
On 9/21/21 9:09 AM, WANG Xuerui wrote: I think cpu=loongarch64 but ARCH=loongarch should be okay... Make it easier on yourself and keep them the same. r~

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread WANG Xuerui
Hi Peter, On 9/21/21 22:42, Peter Maydell wrote: On Mon, 20 Sept 2021 at 18:25, Richard Henderson wrote: On 9/20/21 1:04 AM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui Be consistent with loongarch or loongarch64 everywhere. If there's no loongarch32, and never will be, then there's prob

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread Richard Henderson
On 9/21/21 7:42 AM, Peter Maydell wrote: On Mon, 20 Sept 2021 at 18:25, Richard Henderson wrote: On 9/20/21 1:04 AM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui Be consistent with loongarch or loongarch64 everywhere. If there's no loongarch32, and never will be, then there's probably n

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread Peter Maydell
On Mon, 20 Sept 2021 at 18:25, Richard Henderson wrote: > > On 9/20/21 1:04 AM, WANG Xuerui wrote: > > Signed-off-by: WANG Xuerui > Be consistent with loongarch or loongarch64 everywhere. > > If there's no loongarch32, and never will be, then there's probably no point > in keeping > the '64' su

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread WANG Xuerui
On 9/21/21 22:07, WANG Xuerui wrote: Hi Richard, On 9/21/21 21:30, Richard Henderson wrote: On 9/20/21 11:02 PM, WANG Xuerui wrote: So should I drop the explicit probing for __loongarch64, instead just probe for __loongarch__ and later #error out the non-__loongarch64 cases individually?

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread WANG Xuerui
Hi Richard, On 9/21/21 21:30, Richard Henderson wrote: On 9/20/21 11:02 PM, WANG Xuerui wrote: So should I drop the explicit probing for __loongarch64, instead just probe for __loongarch__ and later #error out the non-__loongarch64 cases individually? I'm ok with checking the __loongarch64

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread Richard Henderson
On 9/20/21 11:02 PM, WANG Xuerui wrote: The loongarch32 tuple will most certainly come into existence some time in the future, but probably bare-metal-only and without a Linux port AFAIK. Ok, I'll bear that in mind when considering target/loongarch/. So should I drop the explicit probing for _

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread WANG Xuerui
Hi Philippe, On 9/21/21 14:59, Philippe Mathieu-Daudé wrote: On 9/21/21 08:02, WANG Xuerui wrote: On 9/21/21 01:23, Richard Henderson wrote: On 9/20/21 1:04 AM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui ---   configure   | 4 +++-   meson.build | 4 +++-   2 files changed, 6 insertions(+),

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-21 Thread Philippe Mathieu-Daudé
On 9/21/21 08:02, WANG Xuerui wrote: On 9/21/21 01:23, Richard Henderson wrote: On 9/20/21 1:04 AM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui ---   configure   | 4 +++-   meson.build | 4 +++-   2 files changed, 6 insertions(+), 2 deletions(-) If there's no loongarch32, and never will be,

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-20 Thread WANG Xuerui
Hi Richard, On 9/21/21 01:23, Richard Henderson wrote: On 9/20/21 1:04 AM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui ---   configure   | 4 +++-   meson.build | 4 +++-   2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 1043ccce4f..f1bc85e71b 100755

Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-20 Thread Richard Henderson
On 9/20/21 1:04 AM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui --- configure | 4 +++- meson.build | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 1043ccce4f..f1bc85e71b 100755 --- a/configure +++ b/configure @@ -659,6 +659,8 @@ elif

[PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts

2021-09-20 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- configure | 4 +++- meson.build | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 1043ccce4f..f1bc85e71b 100755 --- a/configure +++ b/configure @@ -659,6 +659,8 @@ elif check_define __arm__ ; then cpu="arm" el