Re: [PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr

2021-06-21 Thread Philippe Mathieu-Daudé
Cc'ing Craig On 6/14/21 10:37 AM, Richard Henderson wrote: > There were two bugs here: (1) the required endianness was > not present in the MemOp, and (2) we were not providing a > zero-extended input to the bswap as semantics required. > > The best fix is to fold the bswap into the memory operat

[PATCH 25/28] target/mips: Fix gen_mxu_s32ldd_s32lddr

2021-06-14 Thread Richard Henderson
There were two bugs here: (1) the required endianness was not present in the MemOp, and (2) we were not providing a zero-extended input to the bswap as semantics required. The best fix is to fold the bswap into the memory operation, producing the desired result directly. Cc: Philippe Mathieu-Daud