Re: [PATCH 21/22] ppc4xx: Drop empty default cases

2022-08-16 Thread BALATON Zoltan
On Tue, 16 Aug 2022, Cédric Le Goater wrote: On 8/13/22 17:34, BALATON Zoltan wrote: Remove default case labels that do nothing or only there to set a default value that could easily be done at the variable definition instead. May be instead, the default case labels deserve a LOG_GUEST_ERROR o

Re: [PATCH 21/22] ppc4xx: Drop empty default cases

2022-08-16 Thread Cédric Le Goater
On 8/13/22 17:34, BALATON Zoltan wrote: Remove default case labels that do nothing or only there to set a default value that could easily be done at the variable definition instead. May be instead, the default case labels deserve a LOG_GUEST_ERROR or a UNIMP or even g_assert_not_reached() ? C.

[PATCH 21/22] ppc4xx: Drop empty default cases

2022-08-13 Thread BALATON Zoltan
Remove default case labels that do nothing or only there to set a default value that could easily be done at the variable definition instead. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc405_boards.c | 7 +-- hw/ppc/ppc405_uc.c | 29 + hw/ppc/ppc440_uc.c |