Re: [PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-22 Thread Richard Henderson
On 8/22/23 12:54, Warner Losh wrote: As a practical matter, they both consume about the same resources until the MAP_ANON region starts to get populated with data... With PROT_NONE, I think they would have the same effect. If it is to be a backing store for something like malloc, then MAP_ANON

Re: [PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-22 Thread Warner Losh
On Tue, Aug 22, 2023 at 12:11 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/22/23 11:03, Warner Losh wrote: > > Hmm, bug with linux-user as well, because here we should > re-establish the reserved_va > > reservation. > > > > > > ... of the shared memory region we just

Re: [PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-22 Thread Richard Henderson
On 8/22/23 11:03, Warner Losh wrote: Hmm, bug with linux-user as well, because here we should re-establish the reserved_va reservation. ... of the shared memory region we just detached? Right? Correct. On a related note, on FreeBSD is there any practical difference between PROT

Re: [PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-22 Thread Warner Losh
On Sun, Aug 20, 2023 at 9:30 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/19/23 02:48, Karim Taha wrote: > > From: Stacey Son > > > > Signed-off-by: Stacey Son > > Signed-off-by: Karim Taha > > --- > > bsd-user/bsd-mem.h| 72 ++

Re: [PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-20 Thread Richard Henderson
On 8/19/23 02:48, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-mem.h| 72 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 80 insertions(+) diff --git a/bsd-user/bsd-mem.h

Re: [PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-19 Thread Warner Losh
On Sat, Aug 19, 2023 at 3:49 AM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/bsd-mem.h| 72 +++ > bsd-user/freebsd/os-syscall.c | 8 > 2 files changed, 80 insertions(+) > > dif

[PATCH 21/22] Implement shmat(2) and shmdt(2)

2023-08-19 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-mem.h| 72 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 80 insertions(+) diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h index 221ad76d8c..f7