Re: [PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp

2023-08-12 Thread Richard Henderson
On 8/11/23 08:06, Richard Henderson wrote: Basically, test sets SZ flags, where cmp sets SZCO.  I want to add an optimizaton using C, so "cmp 0,x" should not be silently replaced by "test x,x". This patch can be dropped entirely. TEST clears C (which cmp vs 0 would also do). I was mis-remembe

Re: [PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp

2023-08-11 Thread Richard Henderson
On 8/11/23 03:45, Peter Maydell wrote: On Fri, 11 Aug 2023 at 11:26, Peter Maydell wrote: On Tue, 8 Aug 2023 at 04:13, Richard Henderson wrote: Add the parameter to avoid TEST and pass along to tgen_arithi. All current users pass false. Signed-off-by: Richard Henderson --- tcg/i386/tcg-

Re: [PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp

2023-08-11 Thread Peter Maydell
On Fri, 11 Aug 2023 at 11:26, Peter Maydell wrote: > > On Tue, 8 Aug 2023 at 04:13, Richard Henderson > wrote: > > > > Add the parameter to avoid TEST and pass along to tgen_arithi. > > All current users pass false. > > > > Signed-off-by: Richard Henderson > > --- > > tcg/i386/tcg-target.c.inc

Re: [PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp

2023-08-11 Thread Peter Maydell
On Tue, 8 Aug 2023 at 04:13, Richard Henderson wrote: > > Add the parameter to avoid TEST and pass along to tgen_arithi. > All current users pass false. > > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c.inc | 16 > 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp

2023-08-07 Thread Richard Henderson
Add the parameter to avoid TEST and pass along to tgen_arithi. All current users pass false. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tcg/i386/tcg-target.c.inc b/tcg/i386/tcg-target.c.inc i