Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-17 Thread Bernhard Beschow
Am 3. Februar 2025 05:42:55 UTC schrieb Dmitriy Sharikhin : >At Sun, 02/02/2025 at 18:09 +0100, Philippe Mathieu-Daudé writes: >> No clue about compatibility. If you unfortunately need to add it, >> then please address my comments in the next version. >TCA6416 is _way_ more complex device than

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-04 Thread Bernhard Beschow
Am 3. Februar 2025 05:42:55 UTC schrieb Dmitriy Sharikhin : >At Sun, 02/02/2025 at 18:09 +0100, Philippe Mathieu-Daudé writes: >> No clue about compatibility. If you unfortunately need to add it, >> then please address my comments in the next version. >TCA6416 is _way_ more complex device than

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-03 Thread Bernhard Beschow
Am 2. Februar 2025 17:09:06 UTC schrieb "Philippe Mathieu-Daudé" : >On 1/2/25 16:28, Bernhard Beschow wrote: >> >> >> Am 30. Januar 2025 23:05:53 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> Cc'ing AMD folks >>> >>> Hi Bernhard, >>> >>> TL;DR; can't you use the PCF8574 which is a more com

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-02 Thread Dmitriy Sharikhin
At Sun, 02/02/2025 at 18:09 +0100, Philippe Mathieu-Daudé writes: > No clue about compatibility. If you unfortunately need to add it, > then please address my comments in the next version. TCA6416 is _way_ more complex device than PCF8574. Basically PCF8574 is shift register directly connected to I

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-02 Thread Philippe Mathieu-Daudé
On 1/2/25 16:28, Bernhard Beschow wrote: Am 30. Januar 2025 23:05:53 UTC schrieb "Philippe Mathieu-Daudé" : Cc'ing AMD folks Hi Bernhard, TL;DR; can't you use the PCF8574 which is a more complete model of I/O expander? (See hw/gpio/pcf8574.c) If it is software-compatible then I could use

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-01 Thread Bernhard Beschow
Am 30. Januar 2025 23:05:53 UTC schrieb "Philippe Mathieu-Daudé" : >Cc'ing AMD folks > >Hi Bernhard, > >TL;DR; can't you use the PCF8574 which is a more complete model of I/O >expander? (See hw/gpio/pcf8574.c) If it is software-compatible then I could use it. I'm modeling a real board whose d

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-01-30 Thread Philippe Mathieu-Daudé
Cc'ing AMD folks Hi Bernhard, TL;DR; can't you use the PCF8574 which is a more complete model of I/O expander? (See hw/gpio/pcf8574.c) On 20/1/25 21:37, Bernhard Beschow wrote: Xilinx QEMU implements a TCA6416 device model which may be useful for the broader QEMU community, so upstream it. In

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-01-29 Thread Corey Minyard
I'm not sure about ownership here, but from an I2C point of view this all looks ok. Reviewed-by: Corey Minyard On Mon, Jan 20, 2025 at 12:43 PM Bernhard Beschow wrote: > > Xilinx QEMU implements a TCA6416 device model which may be useful for the > broader QEMU community, so upstream it. In the

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-01-28 Thread Bernhard Beschow
Am 21. Januar 2025 03:07:39 UTC schrieb BALATON Zoltan : >On Mon, 20 Jan 2025, Bernhard Beschow wrote: >> Xilinx QEMU implements a TCA6416 device model which may be useful for the >> broader QEMU community, so upstream it. In the Xilinx fork, the device model >> gets compiled whenever CONFIG_CAD

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-01-20 Thread BALATON Zoltan
On Mon, 20 Jan 2025, Bernhard Beschow wrote: Xilinx QEMU implements a TCA6416 device model which may be useful for the broader QEMU community, so upstream it. In the Xilinx fork, the device model gets compiled whenever CONFIG_CADENCE is true, so have it maintained by the "hw/*/cadence_*" maintain

[PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-01-20 Thread Bernhard Beschow
Xilinx QEMU implements a TCA6416 device model which may be useful for the broader QEMU community, so upstream it. In the Xilinx fork, the device model gets compiled whenever CONFIG_CADENCE is true, so have it maintained by the "hw/*/cadence_*" maintainers. The code is based on Xilinx QEMU version