Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-13 Thread Mark Cave-Ayland
On 12/07/2022 15:54, BALATON Zoltan wrote: On Tue, 12 Jul 2022, Mark Cave-Ayland wrote: On 11/07/2022 08:42, Cédric Le Goater wrote: Anything special I should know ? As I don't have access to a G5 I've never tried that, however the qemu-system-ppc64 mac99 is wired differently to the qemu-sy

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-12 Thread BALATON Zoltan
On Tue, 12 Jul 2022, Mark Cave-Ayland wrote: On 11/07/2022 08:42, Cédric Le Goater wrote: Anything special I should know ? As I don't have access to a G5 I've never tried that, however the qemu-system-ppc64 mac99 is wired differently to the qemu-system-ppc mac99 machine so I wouldn't be surp

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-12 Thread Mark Cave-Ayland
On 11/07/2022 08:42, Cédric Le Goater wrote: Anything special I should know ? As I don't have access to a G5 I've never tried that, however the qemu-system-ppc64 mac99 is wired differently to the qemu-system-ppc mac99 machine so I wouldn't be surprised if something is broken there. My norm

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-11 Thread BALATON Zoltan
On Mon, 11 Jul 2022, Mark Cave-Ayland wrote: On 06/07/2022 08:45, Cédric Le Goater wrote: I gave KVM a try on a :     cpu    : PPC970MP, altivec supported     clock    : 2000.00MHz     revision    : 1.0 (pvr 0044 0100)     processor    : 1     cpu    : PPC970MP, altivec support

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-11 Thread Cédric Le Goater
On 7/11/22 09:37, Mark Cave-Ayland wrote: On 06/07/2022 08:45, Cédric Le Goater wrote: On 7/5/22 08:57, Cédric Le Goater wrote: On 7/5/22 08:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-11 Thread Mark Cave-Ayland
On 06/07/2022 08:45, Cédric Le Goater wrote: On 7/5/22 08:57, Cédric Le Goater wrote: On 7/5/22 08:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel He

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-06 Thread Cédric Le Goater
On 7/5/22 08:57, Cédric Le Goater wrote: On 7/5/22 08:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-05 Thread Daniel Henrique Barboza
On 7/5/22 06:44, Mark Cave-Ayland wrote: On 05/07/2022 10:39, Daniel Henrique Barboza wrote: On 7/5/22 03:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42,

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-05 Thread Cédric Le Goater
On 7/5/22 11:39, Daniel Henrique Barboza wrote: On 7/5/22 03:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function ca

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-05 Thread Mark Cave-Ayland
On 05/07/2022 10:39, Daniel Henrique Barboza wrote: On 7/5/22 03:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-05 Thread Daniel Henrique Barboza
On 7/5/22 03:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-04 Thread Cédric Le Goater
On 7/5/22 08:51, Mark Cave-Ayland wrote: On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and cal

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-04 Thread Mark Cave-Ayland
On 04/07/2022 18:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and call it a day. We must provide a way of letti

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-04 Thread Daniel Henrique Barboza
On 7/4/22 14:34, Cédric Le Goater wrote: On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-04 Thread Cédric Le Goater
On 7/2/22 15:34, Daniel Henrique Barboza wrote: On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting callers know if the zero return is legitimat

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-02 Thread Daniel Henrique Barboza
On 7/2/22 03:24, Cédric Le Goater wrote: On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting callers know if the zero return is legitimate or due to an error. Add an Error pointer to k

Re: [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-07-01 Thread Cédric Le Goater
On 6/30/22 21:42, Daniel Henrique Barboza wrote: The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting callers know if the zero return is legitimate or due to an error. Add an Error pointer to kvmppc_read_int_cpu_dt() that will be filled w

[PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-06-30 Thread Daniel Henrique Barboza
The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting callers know if the zero return is legitimate or due to an error. Add an Error pointer to kvmppc_read_int_cpu_dt() that will be filled with an appropriate error, if one occurs. Callers ar