Re: [PATCH 2/8] hvf: Move common code out

2020-12-03 Thread Roman Bolshakov
On Thu, Dec 03, 2020 at 11:13:35PM +0100, Alexander Graf wrote: > > On 03.12.20 19:42, Peter Collingbourne wrote: > > On Thu, Dec 3, 2020 at 1:41 AM Roman Bolshakov > > wrote: > > > On Mon, Nov 30, 2020 at 04:00:11PM -0800, Peter Collingbourne wrote: > > > > What I observe is that when returning

Re: [PATCH 2/8] hvf: Move common code out

2020-12-03 Thread Alexander Graf
On 03.12.20 19:42, Peter Collingbourne wrote: On Thu, Dec 3, 2020 at 1:41 AM Roman Bolshakov wrote: On Mon, Nov 30, 2020 at 04:00:11PM -0800, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: On 01.12.20 00:01, Peter Collingbourne wrote: On Mon, Nov 30, 202

Re: [PATCH 2/8] hvf: Move common code out

2020-12-03 Thread Peter Collingbourne
On Thu, Dec 3, 2020 at 1:41 AM Roman Bolshakov wrote: > > On Mon, Nov 30, 2020 at 04:00:11PM -0800, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: > > > > > > > > > On 01.12.20 00:01, Peter Collingbourne wrote: > > > > On Mon, Nov 30, 2020 at 1:40 PM Alexande

Re: [PATCH 2/8] hvf: Move common code out

2020-12-03 Thread Roman Bolshakov
On Mon, Nov 30, 2020 at 04:00:11PM -0800, Peter Collingbourne wrote: > On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: > > > > > > On 01.12.20 00:01, Peter Collingbourne wrote: > > > On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: > > >> Hi Peter, > > >> > > >> On 30.11.20 22:08, Pete

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Frank Yang
On Mon, Nov 30, 2020 at 2:10 PM Peter Maydell wrote: > On Mon, 30 Nov 2020 at 20:56, Frank Yang wrote: > > We'd actually like to contribute upstream too :) We do want to maintain > > our own downstream though; Android Emulator codebase needs to work > > solidly on macos and windows which has mad

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Roman Bolshakov
On Mon, Nov 30, 2020 at 10:40:49PM +0100, Alexander Graf wrote: > Hi Peter, > > On 30.11.20 22:08, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > > > > > > > > > On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: > > > > Hi Frank, > > > > > > > > Thank

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Alexander Graf
On 01.12.20 01:00, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: On 01.12.20 00:01, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: Hi Peter, On 30.11.20 22:08, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 12:56 P

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Peter Collingbourne
On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: > > > On 01.12.20 00:01, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: > >> Hi Peter, > >> > >> On 30.11.20 22:08, Peter Collingbourne wrote: > >>> On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > >>

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Alexander Graf
On 01.12.20 00:01, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: Hi Peter, On 30.11.20 22:08, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: Hi Frank, Thanks for th

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Peter Collingbourne
On Mon, Nov 30, 2020 at 1:40 PM Alexander Graf wrote: > > Hi Peter, > > On 30.11.20 22:08, Peter Collingbourne wrote: > > On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > >> > >> > >> On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: > >>> Hi Frank, > >>> > >>> Thanks for the update :).

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Peter Collingbourne
On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > > > > On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: >> >> Hi Frank, >> >> Thanks for the update :). Your previous email nudged me into the right >> direction. I previously had implemented WFI through the internal timer >> framework w

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Peter Maydell
On Mon, 30 Nov 2020 at 20:56, Frank Yang wrote: > We'd actually like to contribute upstream too :) We do want to maintain > our own downstream though; Android Emulator codebase needs to work > solidly on macos and windows which has made keeping up with upstream difficult One of the main reasons w

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Alexander Graf
Hi Peter, On 30.11.20 22:08, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: Hi Frank, Thanks for the update :). Your previous email nudged me into the right direction. I previously had implemented WFI t

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Peter Collingbourne
On Mon, Nov 30, 2020 at 12:56 PM Frank Yang wrote: > > > > On Mon, Nov 30, 2020 at 12:34 PM Alexander Graf wrote: >> >> Hi Frank, >> >> Thanks for the update :). Your previous email nudged me into the right >> direction. I previously had implemented WFI through the internal timer >> framework w

Re: [PATCH 2/8] hvf: Move common code out

2020-11-30 Thread Frank Yang
Update: We're not quite sure how to compare the CNTV_CVAL and CNTVCT. But the high CPU usage seems to be mitigated by having a poll interval (like KVM does) in handling WFI: https://android-review.googlesource.com/c/platform/external/qemu/+/1512501 This is loosely inspired by https://elixir.bootl

Re: [PATCH 2/8] hvf: Move common code out

2020-11-27 Thread Frank Yang
Hi all, +Peter Collingbourne I'm a developer on the Android Emulator, which is in a fork of QEMU. Peter and I have been working on an HVF Apple Silicon backend with an eye toward Android guests. We have gotten things to basically switch to Android userspace already (logcat/shell and graphics a

Re: [PATCH 2/8] hvf: Move common code out

2020-11-27 Thread Alexander Graf
On 27.11.20 21:00, Roman Bolshakov wrote: On Thu, Nov 26, 2020 at 10:50:11PM +0100, Alexander Graf wrote: Until now, Hypervisor.framework has only been available on x86_64 systems. With Apple Silicon shipping now, it extends its reach to aarch64. To prepare for support for multiple architectur

Re: [PATCH 2/8] hvf: Move common code out

2020-11-27 Thread Roman Bolshakov
On Thu, Nov 26, 2020 at 10:50:11PM +0100, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's move common code out > into its

[PATCH 2/8] hvf: Move common code out

2020-11-26 Thread Alexander Graf
Until now, Hypervisor.framework has only been available on x86_64 systems. With Apple Silicon shipping now, it extends its reach to aarch64. To prepare for support for multiple architectures, let's move common code out into its own accel directory. Signed-off-by: Alexander Graf --- MAINTAINERS