Re: [PATCH 2/6] migration/colo.c: Use cpu_synchronize_all_states()

2020-05-13 Thread Lukas Straub
On Wed, 13 May 2020 10:47:02 +0100 "Dr. David Alan Gilbert" wrote: > * Lukas Straub (lukasstra...@web.de) wrote: > > cpu_synchronize_all_pre_loadvm() marks all vcpus as dirty, so the > > registers are loaded from CPUState before we continue running > > the vm. However if we failover during checkp

Re: [PATCH 2/6] migration/colo.c: Use cpu_synchronize_all_states()

2020-05-13 Thread Dr. David Alan Gilbert
* Lukas Straub (lukasstra...@web.de) wrote: > cpu_synchronize_all_pre_loadvm() marks all vcpus as dirty, so the > registers are loaded from CPUState before we continue running > the vm. However if we failover during checkpoint, CPUState is not > initialized and the registers are loaded with garbage

[PATCH 2/6] migration/colo.c: Use cpu_synchronize_all_states()

2020-05-11 Thread Lukas Straub
cpu_synchronize_all_pre_loadvm() marks all vcpus as dirty, so the registers are loaded from CPUState before we continue running the vm. However if we failover during checkpoint, CPUState is not initialized and the registers are loaded with garbage. This causes guest hangs and crashes. Fix this by