Re: [PATCH 2/6] accel/tcg: Restrict tb_flush_jmp_cache() from other accelerators

2021-01-20 Thread Richard Henderson
On 1/17/21 6:48 AM, Philippe Mathieu-Daudé wrote: > tb_flush_jmp_cache() is only called within TCG accelerator, > declare it locally. > > Signed-off-by: Philippe Mathieu-Daudé > --- > We could also inline it in cputlb.c, the single user. > --- Yes, I think we should move it to cputlb.c. I have q

Re: [PATCH 2/6] accel/tcg: Restrict tb_flush_jmp_cache() from other accelerators

2021-01-18 Thread Claudio Fontana
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: > tb_flush_jmp_cache() is only called within TCG accelerator, > declare it locally. > > Signed-off-by: Philippe Mathieu-Daudé > --- > We could also inline it in cputlb.c, the single user. That is what I was thinking, I would be more inclined to p

[PATCH 2/6] accel/tcg: Restrict tb_flush_jmp_cache() from other accelerators

2021-01-17 Thread Philippe Mathieu-Daudé
tb_flush_jmp_cache() is only called within TCG accelerator, declare it locally. Signed-off-by: Philippe Mathieu-Daudé --- We could also inline it in cputlb.c, the single user. --- accel/tcg/internal.h | 16 include/exec/exec-all.h | 3 --- accel/tcg/cputlb.c| 1