Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-10 Thread Daniel P . Berrangé
On Wed, Mar 10, 2021 at 02:45:25PM +0100, Greg Kurz wrote: > On Wed, 10 Mar 2021 11:43:58 + > Daniel P. Berrangé wrote: > > > On Tue, Mar 09, 2021 at 09:23:22PM +0100, Greg Kurz wrote: > > > On Tue, 9 Mar 2021 15:17:21 + > > > Stefan Hajnoczi wrote: > > > > > > > On Mon, Mar 08, 2021 at

Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-10 Thread Greg Kurz
On Wed, 10 Mar 2021 11:43:58 + Daniel P. Berrangé wrote: > On Tue, Mar 09, 2021 at 09:23:22PM +0100, Greg Kurz wrote: > > On Tue, 9 Mar 2021 15:17:21 + > > Stefan Hajnoczi wrote: > > > > > On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote: > > > > +g_autofree int *fd = NULL;

Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-10 Thread Greg Kurz
On Wed, 10 Mar 2021 11:27:16 + Stefan Hajnoczi wrote: > On Tue, Mar 09, 2021 at 09:23:22PM +0100, Greg Kurz wrote: > > On Tue, 9 Mar 2021 15:17:21 + > > Stefan Hajnoczi wrote: > > > > > On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote: > > > > +g_autofree int *fd = NULL; >

Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-10 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 09:23:22PM +0100, Greg Kurz wrote: > On Tue, 9 Mar 2021 15:17:21 + > Stefan Hajnoczi wrote: > > > On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote: > > > +g_autofree int *fd = NULL; > > > +size_t fdsize = 0; > > > +int i; > > > > > > /* Read

Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-10 Thread Stefan Hajnoczi
On Tue, Mar 09, 2021 at 09:23:22PM +0100, Greg Kurz wrote: > On Tue, 9 Mar 2021 15:17:21 + > Stefan Hajnoczi wrote: > > > On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote: > > > +g_autofree int *fd = NULL; > > > +size_t fdsize = 0; > > > +int i; > > > > > > /* Read

Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-09 Thread Greg Kurz
On Tue, 9 Mar 2021 15:17:21 + Stefan Hajnoczi wrote: > On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote: > > +g_autofree int *fd = NULL; > > +size_t fdsize = 0; > > +int i; > > > > /* Read header */ > > iov.iov_base = &hdr; > > iov.iov_len = VHOST_USER_HD

Re: [PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-09 Thread Stefan Hajnoczi
On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote: > +g_autofree int *fd = NULL; > +size_t fdsize = 0; > +int i; > > /* Read header */ > iov.iov_base = &hdr; > iov.iov_len = VHOST_USER_HDR_SIZE; > > do { > -size = recvmsg(u->slave_fd, &msgh, 0); >

[PATCH 2/4] vhost-user: Convert slave channel to QIOChannelSocket

2021-03-08 Thread Greg Kurz
The slave channel is implemented with socketpair() : QEMU creates the pair, passes one of the socket to virtiofsd and monitors the other one with the main event loop using qemu_set_fd_handler(). In order to fix a potential deadlock between QEMU and a vhost-user external process (e.g. virtiofsd wit