Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Auger Eric
Hi Thomas, On 9/24/19 1:06 PM, Thomas Huth wrote: > On 24/09/2019 13.02, Auger Eric wrote: >> Hi Thomas, >> >> On 9/23/19 8:09 PM, Thomas Huth wrote: >>> On 23/09/2019 16.31, Auger Eric wrote: Hi Thomas, On 9/21/19 5:04 PM, Thomas Huth wrote: > We are going to make CONFIG_ARM_V7

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Thomas Huth
On 24/09/2019 13.02, Auger Eric wrote: > Hi Thomas, > > On 9/23/19 8:09 PM, Thomas Huth wrote: >> On 23/09/2019 16.31, Auger Eric wrote: >>> Hi Thomas, >>> >>> On 9/21/19 5:04 PM, Thomas Huth wrote: We are going to make CONFIG_ARM_V7M optional, so the related cortex-m CPUs should only be

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Auger Eric
Hi Thomas, On 9/23/19 8:09 PM, Thomas Huth wrote: > On 23/09/2019 16.31, Auger Eric wrote: >> Hi Thomas, >> >> On 9/21/19 5:04 PM, Thomas Huth wrote: >>> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m >>> CPUs should only be created if the switch is enabled. This can best >>

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/23/19 4:34 PM, Peter Maydell wrote: > On Sat, 21 Sep 2019 at 16:04, Thomas Huth wrote: >> >> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m >> CPUs should only be created if the switch is enabled. This can best >> be done if the code resides in a separate file, thus mov

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 19:51, Thomas Huth wrote: > It also sounds like CONFIG_ARM_V7M should rather be renamed to > CONFIG_ARM_MPROFILE or something similar? Depends whether it's visible to end-users or not. If it is, a different name is probably more helpful; if it's just a symbol used in the QE

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Thomas Huth
On 23/09/2019 20.45, Peter Maydell wrote: > On Mon, 23 Sep 2019 at 19:09, Thomas Huth wrote: >> However, there's one thing I currently don't quite understand in this >> code (since I'm not an ARM guy, sorry) : There are references to "v8" in >> m_helper.c, too. Is that related to a separate CPU ty

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 19:09, Thomas Huth wrote: > However, there's one thing I currently don't quite understand in this > code (since I'm not an ARM guy, sorry) : There are references to "v8" in > m_helper.c, too. Is that related to a separate CPU type, ie. should the > v8 code also be available

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Thomas Huth
On 23/09/2019 16.31, Auger Eric wrote: > Hi Thomas, > > On 9/21/19 5:04 PM, Thomas Huth wrote: >> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m >> CPUs should only be created if the switch is enabled. This can best >> be done if the code resides in a separate file, thus mov

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Peter Maydell
On Sat, 21 Sep 2019 at 16:04, Thomas Huth wrote: > > We are going to make CONFIG_ARM_V7M optional, so the related cortex-m > CPUs should only be created if the switch is enabled. This can best > be done if the code resides in a separate file, thus move the related > functions to a new file v7m.c w

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Auger Eric
Hi Thomas, On 9/21/19 5:04 PM, Thomas Huth wrote: > We are going to make CONFIG_ARM_V7M optional, so the related cortex-m > CPUs should only be created if the switch is enabled. This can best > be done if the code resides in a separate file, thus move the related > functions to a new file v7m.c wh

[PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-21 Thread Thomas Huth
We are going to make CONFIG_ARM_V7M optional, so the related cortex-m CPUs should only be created if the switch is enabled. This can best be done if the code resides in a separate file, thus move the related functions to a new file v7m.c which only gets compiled if CONFIG_ARM_V7M is enabled. Signe