Re: [PATCH 2/4] qga: Invert logic on return value in main()

2024-12-04 Thread Konstantin Kostiuk
Hi Michal, Please fix the issue that Jan mentioned. All commits should be logically correct even if it part of one series. Applying this will cause regression. Best Regards, Konstantin Kostiuk. On Wed, Nov 6, 2024 at 6:07 PM Ján Tomko wrote: > On a Monday in 2024, Michal Privoznik wrote: > >C

Re: [PATCH 2/4] qga: Invert logic on return value in main()

2024-11-06 Thread Ján Tomko
On a Monday in 2024, Michal Privoznik wrote: Current logic on return value ('ret' variable) in main() is error prone. The variable is initialized to EXIT_SUCCESS and then set to EXIT_FAILURE on error paths. This makes it very easy to forget to set the variable to indicate error when adding new er

[PATCH 2/4] qga: Invert logic on return value in main()

2024-11-04 Thread Michal Privoznik
Current logic on return value ('ret' variable) in main() is error prone. The variable is initialized to EXIT_SUCCESS and then set to EXIT_FAILURE on error paths. This makes it very easy to forget to set the variable to indicate error when adding new error path, as is demonstrated by handling of ini