Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-07 Thread Michael Walle
Am 2020-07-07 18:30, schrieb Peter Maydell: On Sun, 5 Jul 2020 at 22:10, Philippe Mathieu-Daudé wrote: The 'card is readonly' and 'card inserted' IRQs are not wired. Add a comment in case someone know where to wire them. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist.c | 1 + 1

Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-07 Thread Peter Maydell
On Sun, 5 Jul 2020 at 22:10, Philippe Mathieu-Daudé wrote: > > The 'card is readonly' and 'card inserted' IRQs are not wired. > Add a comment in case someone know where to wire them. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/milkymist.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-07 Thread Alistair Francis
On Mon, Jul 6, 2020 at 7:06 PM Philippe Mathieu-Daudé wrote: > > On 7/6/20 8:32 PM, Alistair Francis wrote: > > On Mon, Jul 6, 2020 at 11:04 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 7/6/20 6:19 PM, Alistair Francis wrote: > >>> On Sun, Jul 5, 2020 at 2:10 PM Philippe Mathieu-Daudé > >

Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-06 Thread Philippe Mathieu-Daudé
On 7/6/20 8:32 PM, Alistair Francis wrote: > On Mon, Jul 6, 2020 at 11:04 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/6/20 6:19 PM, Alistair Francis wrote: >>> On Sun, Jul 5, 2020 at 2:10 PM Philippe Mathieu-Daudé >>> wrote: The 'card is readonly' and 'card inserted' IRQs are not wi

Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-06 Thread Alistair Francis
On Mon, Jul 6, 2020 at 11:04 AM Philippe Mathieu-Daudé wrote: > > On 7/6/20 6:19 PM, Alistair Francis wrote: > > On Sun, Jul 5, 2020 at 2:10 PM Philippe Mathieu-Daudé > > wrote: > >> > >> The 'card is readonly' and 'card inserted' IRQs are not wired. > >> Add a comment in case someone know where

Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-06 Thread Philippe Mathieu-Daudé
On 7/6/20 6:19 PM, Alistair Francis wrote: > On Sun, Jul 5, 2020 at 2:10 PM Philippe Mathieu-Daudé wrote: >> >> The 'card is readonly' and 'card inserted' IRQs are not wired. >> Add a comment in case someone know where to wire them. >> >> Signed-off-by: Philippe Mathieu-Daudé > > I'm not convinc

Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-06 Thread Alistair Francis
On Sun, Jul 5, 2020 at 2:10 PM Philippe Mathieu-Daudé wrote: > > The 'card is readonly' and 'card inserted' IRQs are not wired. > Add a comment in case someone know where to wire them. > > Signed-off-by: Philippe Mathieu-Daudé I'm not convinced adding fixmes or todos in the code is the right dir

[PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-05 Thread Philippe Mathieu-Daudé
The 'card is readonly' and 'card inserted' IRQs are not wired. Add a comment in case someone know where to wire them. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 469e3c4322..1179