Re: [PATCH 2/4] hw/dma: Break the loop when loading descriptions fails

2024-06-04 Thread Frank Chang
Reviewed-by: Frank Chang Fea.Wang 於 2024年6月3日 週一 下午1:48寫道: > > When calling the loading a description function, it should be noticed > that the function may return a failure value. Breaking the loop is one > of the possible ways to handle it. > > Signed-off-by: Fea.Wang > --- > hw/dma/xilinx_a

Re: [PATCH 2/4] hw/dma: Break the loop when loading descriptions fails

2024-06-03 Thread Fea Wang
Hi Edgar, thank you for the advice, I will squash them in the next version of the patch series. Sincerely, Fea On Mon, Jun 3, 2024 at 6:21 PM Edgar E. Iglesias wrote: > On Mon, Jun 3, 2024 at 7:48 AM Fea.Wang wrote: > >> When calling the loading a description function, it should be noticed >>

Re: [PATCH 2/4] hw/dma: Break the loop when loading descriptions fails

2024-06-03 Thread Edgar E. Iglesias
On Mon, Jun 3, 2024 at 7:48 AM Fea.Wang wrote: > When calling the loading a description function, it should be noticed > that the function may return a failure value. Breaking the loop is one > of the possible ways to handle it. > > Signed-off-by: Fea.Wang > Looks good, a nitpick comment, I wo

[PATCH 2/4] hw/dma: Break the loop when loading descriptions fails

2024-06-02 Thread Fea.Wang
When calling the loading a description function, it should be noticed that the function may return a failure value. Breaking the loop is one of the possible ways to handle it. Signed-off-by: Fea.Wang --- hw/dma/xilinx_axidma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -