Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-23 Thread Paolo Bonzini
On 22/09/21 17:47, Philippe Mathieu-Daudé wrote: @@ -637,7 +639,7 @@ static int get_stream_blocksize(BlockBackend *blk)   cmd[0] = MODE_SENSE;   cmd[4] = sizeof(buf); -    ret = scsi_SG_IO_FROM_DEV(blk, cmd, sizeof(cmd), buf, sizeof(buf)); +    ret = scsi_SG_IO_FROM_DEV(blk, cmd, size

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-22 Thread Hannes Reinecke
On 9/22/21 5:47 PM, Philippe Mathieu-Daudé wrote: Hi Hannes, On 11/16/20 19:31, Hannes Reinecke wrote: The current code sets an infinite timeout on SG_IO requests, causing the guest to stall if the host experiences a frame loss. This patch adds an 'io_timeout' parameter for SCSIDevice to make t

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-22 Thread Philippe Mathieu-Daudé
Hi Hannes, On 11/16/20 19:31, Hannes Reinecke wrote: The current code sets an infinite timeout on SG_IO requests, causing the guest to stall if the host experiences a frame loss. This patch adds an 'io_timeout' parameter for SCSIDevice to make the SG_IO timeout configurable, and also shortens th

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-21 Thread Paolo Bonzini
On 21/09/21 07:39, Hannes Reinecke wrote: It would, but then anyone attempting to use tapes via qemu emulation deserves to suffer. Tapes are bitchy even when used normally, so attempting to use them under qemu emulation will land you with lots of unhappy experiences, where the timeout is the le

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-20 Thread Hannes Reinecke
On 9/20/21 8:56 PM, Paolo Bonzini wrote: On Mon, Nov 16, 2020 at 7:31 PM Hannes Reinecke wrote: The current code sets an infinite timeout on SG_IO requests, causing the guest to stall if the host experiences a frame loss. This patch adds an 'io_timeout' parameter for SCSIDevice to make the SG_I

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-20 Thread Paolo Bonzini
On Mon, Nov 16, 2020 at 7:31 PM Hannes Reinecke wrote: > The current code sets an infinite timeout on SG_IO requests, > causing the guest to stall if the host experiences a frame > loss. > This patch adds an 'io_timeout' parameter for SCSIDevice to > make the SG_IO timeout configurable, and also s

[PATCH 2/3] scsi: make io_timeout configurable

2020-11-16 Thread Hannes Reinecke
The current code sets an infinite timeout on SG_IO requests, causing the guest to stall if the host experiences a frame loss. This patch adds an 'io_timeout' parameter for SCSIDevice to make the SG_IO timeout configurable, and also shortens the default timeout to 30 seconds to avoid infinite stalls