Re: [PATCH 2/3] migration/multifd: Unify multifd_send_thread error paths

2023-10-16 Thread Juan Quintela
Fabiano Rosas wrote: > The preferred usage of the Error type is to always set both the return > code and the error when a failure happens. As all code called from the > send thread follows this pattern, we'll always have the return code > and the error set at the same time. > > Aside from the conv

[PATCH 2/3] migration/multifd: Unify multifd_send_thread error paths

2023-10-12 Thread Fabiano Rosas
The preferred usage of the Error type is to always set both the return code and the error when a failure happens. As all code called from the send thread follows this pattern, we'll always have the return code and the error set at the same time. Aside from the convention, in this piece of code thi