Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-22 Thread Daniel P . Berrangé
On Wed, Nov 22, 2023 at 11:38:28AM +0100, Thomas Huth wrote: > On 21/11/2023 12.47, Marc-André Lureau wrote: > > Hi > > > > On Tue, Nov 21, 2023 at 1:45 PM Thomas Huth wrote: > > > > > > On 21/11/2023 10.39, Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Mon, Nov 20, 2023 at 5:36 PM Nic

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-22 Thread Thomas Huth
On 21/11/2023 12.47, Marc-André Lureau wrote: Hi On Tue, Nov 21, 2023 at 1:45 PM Thomas Huth wrote: On 21/11/2023 10.39, Marc-André Lureau wrote: Hi On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: Hi On Thu, Nov 16,

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-22 Thread Alex Bennée
Marc-André Lureau writes: > Hi > > On Tue, Nov 21, 2023 at 1:45 PM Thomas Huth wrote: >> >> On 21/11/2023 10.39, Marc-André Lureau wrote: >> > Hi >> > >> > On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: >> >> >> >> On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: >> >>> Hi

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-21 Thread Marc-André Lureau
Hi On Tue, Nov 21, 2023 at 1:45 PM Thomas Huth wrote: > > On 21/11/2023 10.39, Marc-André Lureau wrote: > > Hi > > > > On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: > >> > >> On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: > >>> Hi > >>> > >>> On Thu, Nov 16, 2023 at 3:54

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-21 Thread Thomas Huth
On 21/11/2023 10.39, Marc-André Lureau wrote: Hi On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: Hi On Thu, Nov 16, 2023 at 3:54 PM Nicholas Piggin wrote: If a chardev socket is not read, it will eventually fill and QE

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-21 Thread Daniel P . Berrangé
On Tue, Nov 21, 2023 at 01:39:03PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: > > > > On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Nov 16, 2023 at 3:54 PM Nicholas Piggin wrote: > > > > > > > > If

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-21 Thread Marc-André Lureau
Hi On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: > > On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: > > Hi > > > > On Thu, Nov 16, 2023 at 3:54 PM Nicholas Piggin wrote: > > > > > > If a chardev socket is not read, it will eventually fill and QEMU > > > can block attempt

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-20 Thread Nicholas Piggin
On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: > Hi > > On Thu, Nov 16, 2023 at 3:54 PM Nicholas Piggin wrote: > > > > If a chardev socket is not read, it will eventually fill and QEMU > > can block attempting to write to it. A difficult bug in avocado > > tests where the console s

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-20 Thread Marc-André Lureau
Hi On Thu, Nov 16, 2023 at 3:54 PM Nicholas Piggin wrote: > > If a chardev socket is not read, it will eventually fill and QEMU > can block attempting to write to it. A difficult bug in avocado > tests where the console socket was not being read from caused this > hang. > > warn if a chardev writ

[PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-16 Thread Nicholas Piggin
If a chardev socket is not read, it will eventually fill and QEMU can block attempting to write to it. A difficult bug in avocado tests where the console socket was not being read from caused this hang. warn if a chardev write is blocked for 100ms. Signed-off-by: Nicholas Piggin --- This is not