[PATCH 2/3] add vnc h264 encoder

2025-04-10 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- ui/meson.build| 1 + ui/vnc-enc-h264.c | 269 ++ ui/vnc-jobs.c | 49 ++--- ui/vnc.c | 21 ui/vnc.h | 21 5 files changed, 346 insertions(+), 15 deletions(-) create mode 1006

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Dietmar Maurer
> > > > +#include > > > > + > > > > +static void libavcodec_destroy_encoder_context(VncState *vs) > > > > > > it's not libavcodec. > > > > I will fix that in v2. > > What about encodebin suggestion? I found no way to configure codec specific option (i.e. x264 zerolatency). I there a way? It is

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Marc-André Lureau
Hi On Tue, Apr 8, 2025 at 1:54 PM Dietmar Maurer wrote: > > > Please resend the series with a cover letter > > (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch) > > Ok, just resend this series with a cover letter and commit message. > (patches unchanged) ok, t

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Dietmar Maurer
> Please resend the series with a cover letter > (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch) Ok, just resend this series with a cover letter and commit message. (patches unchanged) > > +#include > > + > > +static void libavcodec_destroy_encoder_context(V

[PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Dietmar Maurer
This patch implements H264 support for VNC. The RFB protocol extension is defined in: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding Currently the Gstreamer x264enc plugin (software encoder) is used to encode the video stream. The gstreamer pipe is: appsrc ->

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-07 Thread Marc-André Lureau
Hi Please resend the series with a cover letter (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch) Some people prefer when the commit message has content too :) At least, it would be useful if you point to a client that supports the codec and allow us to test/u