Re: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

On Thu, 7 Nov 2024 18:59:07 + Salil Mehta wrote: > Hi Igor, > > Many thanks for taking time to reply. > > > From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org > arm-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Igor > > Mammedov > > Sent: Thursday, November 7, 2024 4:57

RE: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

Hi Igor, Many thanks for taking time to reply. > From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org arm-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Igor > Mammedov > Sent: Thursday, November 7, 2024 4:57 PM > To: Salil Mehta > > On Wed, 6 Nov 2024 19:05:15 + > Sal

Re: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

On Wed, 6 Nov 2024 19:05:15 + Salil Mehta wrote: > Hi Igor, > > Thanks for replying back and the reviews. Please find my replies > inline. > > > From: Igor Mammedov > > Sent: Wednesday, November 6, 2024 4:08 PM > > To: Salil Mehta > > > > On Wed, 6 Nov 2024 14:45:42 + > > Salil

RE: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

Hi Igor, Thanks for replying back and the reviews. Please find my replies inline. > From: Igor Mammedov > Sent: Wednesday, November 6, 2024 4:08 PM > To: Salil Mehta > > On Wed, 6 Nov 2024 14:45:42 + > Salil Mehta wrote: > > > Hi Igor, > > > > > From: qemu-arm-bounces+salil.me

Re: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

On Wed, 6 Nov 2024 14:45:42 + Salil Mehta wrote: > Hi Igor, > > > From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org > arm-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Igor > > Mammedov > > Sent: Wednesday, November 6, 2024 1:57 PM > > To: Salil Mehta > > > > On We

RE: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

Hi Igor, > From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org arm-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Igor > Mammedov > Sent: Wednesday, November 6, 2024 1:57 PM > To: Salil Mehta > > On Wed, 6 Nov 2024 13:03:30 + > Salil Mehta wrote: > > > Checking `is

[PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

Checking `is_present` first can break x86 migration from new Qemu version to old Qemu. This is because CPRS Bit is not defined in the older Qemu register block and will always be 0 resulting in check always failing. Reversing the logic to first check `is_enabled` can alleviate below problem: -

Re: [PATCH 2/3] Fix: Reverse CPUs presence check logic for x86 backward compatability

On Wed, 6 Nov 2024 13:03:30 + Salil Mehta wrote: > Checking `is_present` first can break x86 migration from new Qemu > version to old Qemu. This is because CPRS Bit is not defined in the > older Qemu register block and will always be 0 resulting in check always > failing. Reversing the logic