Re: [PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/22/23 7:05 AM, Stefan Berger wrote: On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. @@ -447,6 +452,15 @@ static uint64_t tpm_tis_mmio_read(void *opaque, hwaddr addr,   r

Re: [PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/22/23 6:24 AM, Stefan Berger wrote: On 3/22/23 07:18, Ninad Palsule wrote: On 3/21/23 6:54 PM, Stefan Berger wrote: @@ -703,6 +726,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,   break;   case TPM_TIS_REG_DATA_FIFO:   case TPM_TIS_REG_DATA_XFIFO ..

Re: [PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Stefan Berger
On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. @@ -447,6 +452,15 @@ static uint64_t tpm_tis_mmio_read(void *opaque, hwaddr addr, return val; } +/* + * A wrapper read f

Re: [PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Stefan Berger
On 3/22/23 07:18, Ninad Palsule wrote: On 3/21/23 6:54 PM, Stefan Berger wrote: @@ -703,6 +726,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,   break;   case TPM_TIS_REG_DATA_FIFO:   case TPM_TIS_REG_DATA_XFIFO ... TPM_TIS_REG_DATA_XFIFO_END: + you can re

Re: [PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-22 Thread Ninad Palsule
On 3/21/23 6:54 PM, Stefan Berger wrote: On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. This commit includes changes for the common code. - Added support for the new checksum regis

Re: [PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-21 Thread Stefan Berger
On 3/21/23 01:30, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. This commit includes changes for the common code. - Added support for the new checksum registers which are required for the I2C supp

[PATCH 2/3] Add support for TPM devices over I2C bus

2023-03-21 Thread Ninad Palsule
Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. This commit includes changes for the common code. - Added support for the new checksum registers which are required for the I2C support. The checksum calculation is handled in t